diff --git a/src/java.net.http/share/classes/jdk/internal/net/http/ResponseSubscribers.java b/src/java.net.http/share/classes/jdk/internal/net/http/ResponseSubscribers.java index e7b4ff806d0..b24b75da8c3 100644 --- a/src/java.net.http/share/classes/jdk/internal/net/http/ResponseSubscribers.java +++ b/src/java.net.http/share/classes/jdk/internal/net/http/ResponseSubscribers.java @@ -552,13 +552,13 @@ public void onSubscribe(Flow.Subscription s) { closed = this.closed; if (!closed) { this.subscription = s; + assert buffers.remainingCapacity() > 1; // should contain at least 2 } } if (closed) { s.cancel(); return; } - assert buffers.remainingCapacity() > 1; // should contain at least 2 if (debug.on()) debug.log("onSubscribe: requesting " + Math.max(1, buffers.remainingCapacity() - 1)); diff --git a/src/java.net.http/share/classes/jdk/internal/net/http/Stream.java b/src/java.net.http/share/classes/jdk/internal/net/http/Stream.java index ef0fe7c0a6d..a7dd61d7c9d 100644 --- a/src/java.net.http/share/classes/jdk/internal/net/http/Stream.java +++ b/src/java.net.http/share/classes/jdk/internal/net/http/Stream.java @@ -184,10 +184,9 @@ private void schedule() { if (subscriber == null) { // can't process anything yet return; - } else { - if (debug.on()) debug.log("subscribing user subscriber"); - subscriber.onSubscribe(userSubscription); } + if (debug.on()) debug.log("subscribing user subscriber"); + subscriber.onSubscribe(userSubscription); } while (!inputQ.isEmpty()) { Http2Frame frame = inputQ.peek(); @@ -420,7 +419,7 @@ CompletableFuture receiveData(BodySubscriber bodySubscriber, Executor exec responseBodyCF.completeExceptionally(t); } - // ensure that the body subscriber will be subsribed and onError() is + // ensure that the body subscriber will be subscribed and onError() is // invoked pendingResponseSubscriber = bodySubscriber; sched.runOrSchedule(); // in case data waiting already to be processed, or error @@ -600,9 +599,9 @@ void incoming_reset(ResetFrame frame) { Flow.Subscriber subscriber = responseSubscriber == null ? pendingResponseSubscriber : responseSubscriber; if (response == null && subscriber == null) { - // we haven't receive the headers yet, and won't receive any! + // we haven't received the headers yet, and won't receive any! // handle reset now. - handleReset(frame, subscriber); + handleReset(frame, null); } else { // put it in the input queue in order to read all // pending data frames first. Indeed, a server may send