Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW]: UNSAFE: An UNcertain Structure And Fragility Ensemble framework for property-level flood risk estimation #7527

Open
editorialbot opened this issue Nov 25, 2024 · 6 comments
Assignees
Labels
Python review TeX Track: 5 (DSAIS) Data Science, Artificial Intelligence, and Machine Learning

Comments

@editorialbot
Copy link
Collaborator

Submitting author: @abpoll (Adam Pollack)
Repository: https://github.com/abpoll/unsafe
Branch with paper.md (empty if default branch):
Version: v0.1
Editor: @atrisovic
Reviewers: @erexer, @yc-lin-geo
Archive: Pending

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/fc91d0c173590f9987a46d210da9c46d"><img src="https://joss.theoj.org/papers/fc91d0c173590f9987a46d210da9c46d/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/fc91d0c173590f9987a46d210da9c46d/status.svg)](https://joss.theoj.org/papers/fc91d0c173590f9987a46d210da9c46d)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@erexer & @yc-lin-geo, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @atrisovic know.

Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest

Checklists

@erexer, please create your checklist typing: @editorialbot generate my checklist

@yc-lin-geo, please create your checklist typing: @editorialbot generate my checklist

@editorialbot
Copy link
Collaborator Author

Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.2139/ssrn.4396826 is OK
- 10.1038/s44221-023-00106-4 is OK
- 10.1016/j.jhydrol.2024.131055 is OK
- 10.1016/j.autcon.2023.105258 is OK
- 10.1111/jfr3.12068 is OK
- 10.1080/10527001.2020.1836915 is OK
- 10.1080/09599916.2020.1807587 is OK
- 10.1257/pandp.20231102 is OK
- 10.1111/jfr3.12889 is OK
- 10.1038/s41467-020-15264-2 is OK
- 10.5194/nhess-10-1697-2010 is OK
- 10.1088/1748-9326/11/9/094014 is OK
- 10.1061/(asce)nh.1527-6996.0000167 is OK
- 10.1111/jfr3.12851 is OK
- 10.1038/s41558-021-01265-6 is OK
- 10.1061/(ASCE)1527-6988(2006)7:2(40) is OK
- 10.1061/(ASCE)1527-6988(2006)7:2(72) is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: What is Delft-FIAT?
- No DOI given, and none found for title: National Structure Inventory Technical Documentati...
- No DOI given, and none found for title: Hazard Mitigation Assistance Loss Avoidance Study ...
- No DOI given, and none found for title: go-consequences: A lightweight consequences comput...
- No DOI given, and none found for title: HEC-FDA
- No DOI given, and none found for title: HEC-FIA Users Manual
- No DOI given, and none found for title: FAST: Hazus - Flood Assessment Structure Tool
- No DOI given, and none found for title: North Atlantic Coast Comprehensive Study: Resilien...

❌ MISSING DOIs

- 10.1029/2018ef001074 may be a valid DOI for title: Probabilistic models significantly reduce uncertai...

❌ INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.90  T=0.05 s (530.0 files/s, 312930.2 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
HTML                             1           1326              2           7671
TeX                              2             37             10           1093
Python                           7            282            804            719
Jupyter Notebook                 3              0           1563            537
Markdown                         7             92              0            216
YAML                             4             23            232            127
TOML                             1              1              0             25
-------------------------------------------------------------------------------
SUM:                            25           1761           2611          10388
-------------------------------------------------------------------------------

Commit count by author:

   106	Adam Pollack
     1	James Doss-Gollin

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 1077

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

✅ License found: BSD 2-Clause "Simplified" License (Valid open source OSI approved license)

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Python review TeX Track: 5 (DSAIS) Data Science, Artificial Intelligence, and Machine Learning
Projects
None yet
Development

No branches or pull requests

2 participants