Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW]: FELINE: A tool to detect emission line galaxies in 3d data #7528

Open
editorialbot opened this issue Nov 25, 2024 · 7 comments
Open
Assignees
Labels
C Cuda Python review TeX Track: 1 (AASS) Astronomy, Astrophysics, and Space Sciences

Comments

@editorialbot
Copy link
Collaborator

Submitting author: @enthusi (Martin Wendt)
Repository: https://github.com/enthusi/feline
Branch with paper.md (empty if default branch):
Version: 1.0.0
Editor: @ivastar
Reviewers: @smutch, @bronreichardtchu
Archive: Pending

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/a575acd1ffab0604de7e26eb83fd9bdc"><img src="https://joss.theoj.org/papers/a575acd1ffab0604de7e26eb83fd9bdc/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/a575acd1ffab0604de7e26eb83fd9bdc/status.svg)](https://joss.theoj.org/papers/a575acd1ffab0604de7e26eb83fd9bdc)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@smutch & @bronreichardtchu, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @ivastar know.

Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest

Checklists

@smutch, please create your checklist typing: @editorialbot generate my checklist

@bronreichardtchu, please create your checklist typing: @editorialbot generate my checklist

@editorialbot editorialbot added C Cuda Python review Track: 1 (AASS) Astronomy, Astrophysics, and Space Sciences labels Nov 25, 2024
@editorialbot
Copy link
Collaborator Author

Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1051/0004-6361/201629507 is OK
- 10.1117/12.856027 is OK
- 10.1051/0004-6361/202244187 is OK
- 10.1002/asna.20220091 is OK
- 10.1093/mnras/stad357 is OK
- 10.1093/mnras/stad3764 is OK
- 10.1051/0004-6361/202348725 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: MUSE Commissioning
- No DOI given, and none found for title: MusE GAs FLOw and Wind (MEGAFLOW) XII. Rationale a...

❌ MISSING DOIs

- None

❌ INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.90  T=0.06 s (520.3 files/s, 165124.6 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          19           1455           2899           4091
Markdown                         5            112              0            382
C                                1             60             46            302
CUDA                             1             29             25            200
TeX                              1             11              0            149
make                             1             31              4            135
YAML                             2             14              4             75
Bourne Shell                     1             16             15             67
JSON                             1              0              0             34
-------------------------------------------------------------------------------
SUM:                            32           1728           2993           5435
-------------------------------------------------------------------------------

Commit count by author:

   108	osoth
   102	Oskar Soth
    82	marvin
    34	soth1
    23	Martin Wendt
     2	Marvin Henschel
     1	enthusi

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 1006

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

✅ License found: BSD 3-Clause "New" or "Revised" License (Valid open source OSI approved license)

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@ivastar
Copy link

ivastar commented Nov 25, 2024

@smutch, @bronreichardtchu thank you for agreeing to review this paper! The instructions are above. Don't hesitate to reach out to me if you have questions or concerns. Considering that we are just starting the review, it would be great to have the first round of reports before the holidays.

@enthusi sincere apologies this took so long. Hopefully progress will be swift going forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C Cuda Python review TeX Track: 1 (AASS) Astronomy, Astrophysics, and Space Sciences
Projects
None yet
Development

No branches or pull requests

2 participants