Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typesetting corrections have status pending forever #214

Open
joemull opened this issue Jul 12, 2024 · 0 comments
Open

Typesetting corrections have status pending forever #214

joemull opened this issue Jul 12, 2024 · 0 comments
Labels
bug Something isn't working dev-ready medium

Comments

@joemull
Copy link
Member

joemull commented Jul 12, 2024

Problem

The view which supposedly marks typesetting corrections as completed never seems to run:

https://github.com/BirkbeckCTP/typesetting/blob/b641acb277e7f8e0ec392f9ae3473642a0396202/views.py#L902-L906

Here is an example of TypesettingCorrection objects in production from several years ago:

image

The fields which are not touched are date_completed and date_declined.

Proposed solution

Deprecate these fields, as well as the status property, and use the corrected property as the sole measure of status.

@joemull joemull added the bug Something isn't working label Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dev-ready medium
Projects
None yet
Development

No branches or pull requests

1 participant