Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On flow names, external versions and URI-safe characters #166

Open
PGijsbers opened this issue Jul 12, 2024 · 0 comments
Open

On flow names, external versions and URI-safe characters #166

PGijsbers opened this issue Jul 12, 2024 · 0 comments
Labels
Flows Flow endpoints proposal We want to discuss this to decide if it should be implemented

Comments

@PGijsbers
Copy link
Contributor

The flow/exists endpoint (#31) currently supports both GET and POST requests because there are names and/or external versions which contain characters which would make it an invalid path if added to the URI. I think we should make a decision to either always require a POST request, or to reconsidered the allowed values for flow names and external versions. I think it's confusing that now there are two endpoints with the same purpose, especially since the hidden POST endpoint is the one actually able to retrieve all the flows. The problem with the approach that restricts names/version characters is that changing keeps the problem with currently published flows. These cannot easily be updated, as it also requires changes to the openml-python API if it needs to support the migrated scheme.

Proposal: Remove the GET endpoint, and only support POST.

@PGijsbers PGijsbers added Flows Flow endpoints proposal We want to discuss this to decide if it should be implemented labels Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Flows Flow endpoints proposal We want to discuss this to decide if it should be implemented
Projects
None yet
Development

No branches or pull requests

1 participant