Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Dev/1.8/enhance tests #226

Open
wants to merge 4 commits into
base: rel/1.8
Choose a base branch
from
Open

Conversation

adamfarquhar
Copy link
Contributor

@adamfarquhar adamfarquhar commented Nov 13, 2024

This PR implements the changes in PR#191 and PR#190. It also makes flake8 happier (these are mostly changes to line length and switching from a single to a double quote as a default for starting strings.

I recommend closing #190 and #191 with a note that they have been implemented in #226.

@adamfarquhar adamfarquhar marked this pull request as ready for review November 13, 2024 10:13
@carlwilson carlwilson self-requested a review November 13, 2024 10:55
Copy link
Member

@carlwilson carlwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine, the majority are reformatting changes. I looked more closely at the changes to fido.py to fix the blocking issue. Agree about #190 and #191, as well as the original issue #189 when the release goes out.

Many thanks.

@adamfarquhar adamfarquhar changed the title Dev/1.8/enhance tests FIX: Dev/1.8/enhance tests Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants