Skip to content
This repository has been archived by the owner on Jan 1, 2020. It is now read-only.

do not use class name publicly #57

Open
dbu opened this issue Nov 17, 2013 · 1 comment
Open

do not use class name publicly #57

dbu opened this issue Nov 17, 2013 · 1 comment

Comments

@dbu
Copy link
Collaborator

dbu commented Nov 17, 2013

the metadata drivers (i.e. xml driver) should read the "name" for a type from the metadata, instead of determining it from the class. this means that for every request, we will need to know the full list of mapped data - meaning we should start to cache compiled metadata for performance reason.

see AbstractRdfDriver::objectToName

@flack
Copy link
Collaborator

flack commented Nov 17, 2013

To some extent, this is already implemented in the array driver (see https://github.com/flack/createphp/blob/master/src/Midgard/CreatePHP/Metadata/RdfDriverArray.php#L207), although I'm not sure if this is good enough. We could add a name attribute to the type tag in XML easily enough, but I'm not yet sure how the lookup is supposed to work

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants