add ngx error log while get wrong code in ngx.exit

Author: rainingmaster

src/ngx_http_lua_control.c

@@ -325,14 +325,20 @@ ngx_http_lua_ngx_exit(lua_State *L)
                                | NGX_HTTP_LUA_CONTEXT_SSL_SESS_STORE
                                | NGX_HTTP_LUA_CONTEXT_SSL_SESS_FETCH);
 
-    /* rc is useless in bodyfilter phase */
+    rc = (ngx_int_t) luaL_checkinteger(L, 1);
+
     if (ctx->context & NGX_HTTP_LUA_CONTEXT_BODY_FILTER) {
+
+        if (rc != NGX_ERROR && rc < 400) {
+            ngx_log_error(NGX_LOG_ERR, r->connection->log, 0, "attempt to "
+                          "exit with the code smaller than 400 and not "
+                          "ngx.ERROR");
+        }
+
         ctx->body_exited = 1;
         return 0;
     }
 
-    rc = (ngx_int_t) luaL_checkinteger(L, 1);
-
     if (ctx->context & (NGX_HTTP_LUA_CONTEXT_SSL_CERT
                         | NGX_HTTP_LUA_CONTEXT_SSL_SESS_STORE
                         | NGX_HTTP_LUA_CONTEXT_SSL_SESS_FETCH))
@@ -488,8 +494,14 @@ ngx_http_lua_ffi_exit(ngx_http_request_t *r, int status, u_char *err,
         return NGX_ERROR;
     }
 
-    /* rc is useless in bodyfilter phase */
     if (ctx->context & NGX_HTTP_LUA_CONTEXT_BODY_FILTER) {
+
+        if (status != NGX_ERROR && status < 400) {
+            ngx_log_error(NGX_LOG_ERR, r->connection->log, 0, "attempt to "
+                          "exit with the code smaller than 400 and not "
+                          "ngx.ERROR");
+        }
+
         ctx->body_exited = 1;
         return NGX_OK;
     }

t/082-body-filter.t

@@ -10,7 +10,7 @@ log_level('debug');
 
 repeat_each(2);
 
-plan tests => repeat_each() * (blocks() * 3 + 8);
+plan tests => repeat_each() * (blocks() * 3 + 13);
 
 #no_diff();
 no_long_string();
@@ -859,6 +859,8 @@ API disabled in the context of body_filter_by_lua*
 111
 --- error_code: 200
 --- no_error_log
+[error]
+[alert]
 
 
 
@@ -880,7 +882,8 @@ API disabled in the context of body_filter_by_lua*
 --- response_body
 111
 --- error_code: 200
---- no_error_log
+--- error_log
+attempt to exit with the code smaller than 400 and not ngx.ERROR
 
 
 
@@ -907,3 +910,5 @@ API disabled in the context of body_filter_by_lua*
 222
 --- error_code: 200
 --- no_error_log
+[error]
+[alert]