From 6a58d6cd03cbadefab9a114a02b6f92c067f692f Mon Sep 17 00:00:00 2001 From: Tim te Beek Date: Wed, 19 Jun 2024 15:52:52 +0200 Subject: [PATCH] Drop Java 17 requirement through rewrite-third-party (#531) --- build.gradle.kts | 1 - .../testing/assertj/IsEqualToEmptyString.java | 3 --- src/main/resources/META-INF/rewrite/assertj.yml | 17 ----------------- 3 files changed, 21 deletions(-) diff --git a/build.gradle.kts b/build.gradle.kts index 4efd2fa0e..4f3662b82 100644 --- a/build.gradle.kts +++ b/build.gradle.kts @@ -34,7 +34,6 @@ dependencies { implementation("org.openrewrite:rewrite-maven") implementation("org.openrewrite.recipe:rewrite-java-dependencies:$rewriteVersion") implementation("org.openrewrite.recipe:rewrite-static-analysis:$rewriteVersion") - implementation("org.openrewrite.recipe:rewrite-third-party:$rewriteVersion") runtimeOnly("org.openrewrite:rewrite-java-17") compileOnly("org.projectlombok:lombok:latest.release") diff --git a/src/main/java/org/openrewrite/java/testing/assertj/IsEqualToEmptyString.java b/src/main/java/org/openrewrite/java/testing/assertj/IsEqualToEmptyString.java index 184ef6dee..fb014fd94 100644 --- a/src/main/java/org/openrewrite/java/testing/assertj/IsEqualToEmptyString.java +++ b/src/main/java/org/openrewrite/java/testing/assertj/IsEqualToEmptyString.java @@ -30,10 +30,7 @@ /** * AssertJ has a more idiomatic way of asserting that a String is empty. * This recipe will find instances of `assertThat(String).isEqualTo("")` and replace them with `isEmpty()`. - * - * @deprecated Use {@link tech.picnic.errorprone.refasterrules.AssertJStringRulesRecipes.AbstractStringAssertStringIsEmptyRecipe} instead. */ -@Deprecated public class IsEqualToEmptyString extends Recipe { private static final MethodMatcher IS_EQUAL_TO = new MethodMatcher("org.assertj.core.api.AbstractStringAssert isEqualTo(java.lang.String)"); diff --git a/src/main/resources/META-INF/rewrite/assertj.yml b/src/main/resources/META-INF/rewrite/assertj.yml index f928d283a..2695a5dd0 100644 --- a/src/main/resources/META-INF/rewrite/assertj.yml +++ b/src/main/resources/META-INF/rewrite/assertj.yml @@ -28,22 +28,6 @@ recipeList: - org.openrewrite.java.testing.assertj.SimplifyChainedAssertJAssertions - org.openrewrite.java.testing.assertj.IsEqualToEmptyString - - tech.picnic.errorprone.refasterrules.AssertJBigDecimalRulesRecipes - - tech.picnic.errorprone.refasterrules.AssertJBigIntegerRulesRecipes - - tech.picnic.errorprone.refasterrules.AssertJBooleanRulesRecipes - - tech.picnic.errorprone.refasterrules.AssertJByteRulesRecipes - - tech.picnic.errorprone.refasterrules.AssertJCharSequenceRulesRecipes - - tech.picnic.errorprone.refasterrules.AssertJDoubleRulesRecipes - - tech.picnic.errorprone.refasterrules.AssertJFloatRulesRecipes - - tech.picnic.errorprone.refasterrules.AssertJIntegerRulesRecipes - - tech.picnic.errorprone.refasterrules.AssertJLongRulesRecipes - - tech.picnic.errorprone.refasterrules.AssertJNumberRulesRecipes - - tech.picnic.errorprone.refasterrules.AssertJPrimitiveRulesRecipes - - tech.picnic.errorprone.refasterrules.AssertJRulesRecipes - - tech.picnic.errorprone.refasterrules.AssertJShortRulesRecipes - - tech.picnic.errorprone.refasterrules.AssertJStringRulesRecipes - - tech.picnic.errorprone.refasterrules.AssertJThrowingCallableRulesRecipes - --- type: specs.openrewrite.org/v1beta/recipe name: org.openrewrite.java.testing.assertj.StaticImports @@ -381,4 +365,3 @@ recipeList: version: 3.x onlyIfUsing: org.assertj.core.api.Assertions acceptTransitive: true - - tech.picnic.errorprone.refasterrules.JUnitToAssertJRulesRecipes