ExplicitPluginGroupId wrongly matches on maven enforcer rule configuration

[Bananeweizen]

What version of OpenRewrite are you using?

maven plugin 5.47.3

What is the smallest, simplest way to reproduce the problem?

Have this maven enforcer configuration in a pom.xml.

<plugin>
	<groupId>org.apache.maven.plugins</groupId>
	<artifactId>maven-enforcer-plugin</artifactId>
	<configuration>
		<rules>
			<requireSameVersions>
				<plugins>
					<plugin>org.eclipse.tycho:*</plugin>
				</plugins>
			</requireSameVersions>
		</rules>
	</configuration>
</plugin>

Run org.openrewrite.maven.cleanup.ExplicitPluginGroupId.

What did you expect to see?

No change.

What did you see instead?

The content of the most inner nested plugin tag has been changed to this:

<plugin>
	<groupId>org.apache.maven.plugins</groupId>org.eclipse.tycho:*
</plugin>

The recipe wrongly assumes the plugin tag to be one of those tags that contain groupid, artifactid, etc., but that's not the case here. It might be useful to require a potential plugin tag to contain a nested artifactId tag, that field should be mandatory everywhere, right?

Are you interested in contributing a fix to OpenRewrite?

[timtebeek]

Thanks for logging an issue @Bananeweizen ! We can either fix this in the recipe itself, or in the isPluginTag() it uses.

rewrite/rewrite-maven/src/main/java/org/openrewrite/maven/cleanup/ExplicitPluginGroupId.java

Line 47 in 0826417

if (isPluginTag() && !t.getChild("groupId").isPresent()) {

I'm leaning towards adding a && t.getChild("artifactId").isPresent() in the recipe, as that would have the least performance impact, and is unlikely to negatively affect other use cases.