Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@table_from_file needs documenting and making more ergonomic #2097

Open
evansd opened this issue Sep 6, 2024 · 1 comment
Open

@table_from_file needs documenting and making more ergonomic #2097

evansd opened this issue Sep 6, 2024 · 1 comment

Comments

@evansd
Copy link
Contributor

evansd commented Sep 6, 2024

We may not love the API here, but it's already in use and requires ad-hoc explanation each time. See e.g.
https://bennettoxford.slack.com/archives/C01D7H9LYKB/p1724860666540569

Where the file being loaded has the structure given by another dataset definition we have the option of providing a much simpler API along the lines of:

new_table = table_from_file("path/to/file.arrow", other_dataset_definition.dataset)

i.e. we can use the existing dataset definition to provide the expected columns without needing to define them manually.

@evansd
Copy link
Contributor Author

evansd commented Oct 8, 2024

Another instance where we've had to explain this ad-hoc:
https://bennettoxford.slack.com/archives/C01D7H9LYKB/p1728384889288909

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant