Full job id matching #740
Merged
Full job id matching #740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Providence-o
force-pushed
the
madwort-and-providence/full-job-id-matching
branch
from
424e8c0
to
416d649
Compare
madwort
force-pushed
the
madwort-and-providence/full-job-id-matching
branch
from
f8547b0
to
ef497e4
Compare
evansd
approved these changes
Oct 4, 2024
There was a problem hiding this comment.
This looks correct to me, and really nice to see the test coverage improving here as well. Great job!
I've pointed out a possible simplification, but it's not a big deal and I'm happy for this to go as is.
When you come to merge this, instead of merging directly could you click the down arrow and use the "Squash and merge" option?
We generally use the "Create a merge commit" option only when the commits have been specifically crafted to make sense on their own. And when the commits just reflect the development workflow we use "Squash and merge" which means they end of as a single commit in the project history.
|
Nb. my gpg key had expired whilst I was working on this, hence |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kill_jobcli command should not require confirmation when full job ID is specified #738