osgDB hardcodes path to build machine

[skelly-energid]

The FileUtils.cpp function appendInstallationLibraryFilePaths returns OSG_DEFAULT_LIBRARY_PATH, which is set in cmake:

ADD_DEFINITIONS(-DOSG_DEFAULT_LIBRARY_PATH=\"${CMAKE_INSTALL_PREFIX}/${OSG_INSTALL_LIBDIR}/${OSG_PLUGINS}\")

The ${CMAKE_INSTALL_PREFIX} is hardcoded, meaning that the path on the build machine is searched for plugins. That is inappropriate. Instead, osgDB should search relative to the osgDB library itself.

[skelly-energid]

For reference, appendInstallationLibraryFilePaths can be patched like so to find the plugin relative to the osgDB binary:

    Dl_info info;
    int result = dladdr(reinterpret_cast<void *>(&osgDB::findFileInDirectory), &info);
    if (result > 0 && info.dli_fname) {
        filepath.push_back(dirname(const_cast<char*>(info.dli_fname)));
    }

An implementation for Windows/Apple is also possible, but left as an excercise :).

[openscenegraph]

On Wed, 1 Apr 2020 at 12:56, skelly-energid ***@***.***> wrote: For reference, appendInstallationLibraryFilePaths can be patched like so to find the plugin relative to the osgDB binary: Dl_info info; int result = dladdr(reinterpret_cast<void *>(&osgDB::findFileInDirectory), &info); if (result > 0 && info.dli_fname) { filepath.push_back(dirname(const_cast<char*>(info.dli_fname))); } An implementation for Windows/Apple is also possible, but left as an excercise :).

We are all busy so of you have improvements that you'd like rolled into the core OSG please generated a PR for them. Thanks.