Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP2 plugin crash on invalid file #978

Open
mikedig opened this issue Aug 4, 2020 · 0 comments
Open

JP2 plugin crash on invalid file #978

mikedig opened this issue Aug 4, 2020 · 0 comments

Comments

@mikedig
Copy link

mikedig commented Aug 4, 2020

If you call readImage with a JP2 file that exists on disk, but is an invalid JP2 file, a crash occurs here https://github.com/openscenegraph/OpenSceneGraph/blame/master/src/osgPlugins/jp2/ReaderWriterJP2.cpp#L239. I noticed the readImage call that reads from a stream has a null check (https://github.com/openscenegraph/OpenSceneGraph/blame/master/src/osgPlugins/jp2/ReaderWriterJP2.cpp#L304) before continuing on, and I was thinking the file version should also contain this check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant