Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FaIR 1.6 HFC mis-labelled forcing ordering #65

Open
chrisroadmap opened this issue May 2, 2022 · 0 comments
Open

FaIR 1.6 HFC mis-labelled forcing ordering #65

chrisroadmap opened this issue May 2, 2022 · 0 comments

Comments

@chrisroadmap
Copy link
Contributor

I suspect index ordering of the minor F-gases is wrong. This is only a problem if you care about the individual gas forcings rather than the total minor forcing (and even then, I don't suspect the code is numerically wrong, just that some gases have the wrong name).

in https://github.com/openscm/openscm-runner/blob/master/src/openscm_runner/adapters/fair_adapter/_run_fair.py

    data["Effective Radiative Forcing|HFC23"] = forcing[:, 6]
    data["Effective Radiative Forcing|HFC32"] = forcing[:, 7]
    data["Effective Radiative Forcing|HFC125"] = forcing[:, 8]
    data["Effective Radiative Forcing|HFC134a"] = forcing[:, 9]
    data["Effective Radiative Forcing|HFC143a"] = forcing[:, 10]
    data["Effective Radiative Forcing|HFC227ea"] = forcing[:, 11]
    data["Effective Radiative Forcing|HFC245fa"] = forcing[:, 12]
    data["Effective Radiative Forcing|HFC4310mee"] = forcing[:, 13]

This error is probably also true in the concentrations.

In the original FaIR code, the emissions are in the order [HFC23, HFC32, HFC43-10, HFC125, HFC134a, HFC143a, HFC227ea, HFC245fa].

The fix is to move Effective Radiative Forcing|HFC4310mee to index 8 and shift the following gases up one position.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant