Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GitHub Request] Add more people to the triage team #240

Open
msfroh opened this issue Dec 9, 2024 · 9 comments
Open

[GitHub Request] Add more people to the triage team #240

msfroh opened this issue Dec 9, 2024 · 9 comments

Comments

@msfroh
Copy link

msfroh commented Dec 9, 2024

What is the type of request?

User Permission

Details of the request

I've been talking with a few OpenSearch core maintainers (mostly @mch2 and @andrross) about how silly it is that we have regular contributors who still need to ask to get issues assigned to them, because they don't have permission to assign issues to themselves.

If we add people to the triage team, they would be able to assign issues and add/remove tags.

Additional information to support your request

I would like to propose that the following folks be added to the triage team:

This is mostly a list from the top of my head, so it's not exhaustive. Other folks who have been actively contributing to OpenSearch should probably be added too.

When does this request need to be completed?

Normal priority -- by late December / early January would be great.

Notes

Track the progress of your request here: https://github.com/orgs/opensearch-project/projects/208/views/33.
Member of @opensearch-project/admin will take a look at the request soon.
Thanks!

@peterzhuamazon
Copy link
Member

Hi @msfroh,

In order to add someone to triage team, we need to first invite them to the org.
There is a limit number of seats available now for the org before we need to purchase more.

I think there are two ways to solve this:

  1. Someone make a comment in the issue then maintainer can assign them
  2. Add a workflow to allow the bot to auto assign people to issue (with certain label or related comments?)

Either of above might be easier than keep adding more and more folks to the triage team just to get assigned to an issue.

Thanks.

@dblock
Copy link
Member

dblock commented Dec 9, 2024

@peterzhuamazon Does the org have people that have been inactive for a long time? Can we remove them?

@peterzhuamazon
Copy link
Member

Hi @dblock we would need a list of members to be removed from the org (not team) in order to have more seats.
Is there a list somewhere we can go through and decide?

Thanks.

@dblock
Copy link
Member

dblock commented Dec 10, 2024

I don't have a list, but was hoping the metrics folks could generate a list/dashboard of org members vs. their engagement in the org, cc @prudhvigodithi.

@prudhvigodithi
Copy link
Member

prudhvigodithi commented Dec 10, 2024

The metrics project today collects user (contributor) activities, example

{
  "_index": "github-user-activity-events-12-2024",
  "_id": "b66afd02-b687-11ef-8dba-ec9dda21f2f7",
  "_version": 1,
  "_score": null,
  "_source": {
    "sender": "msfroh",
    "organization": "opensearch-project",
    "action": "submitted",
    "created_at": "2024-12-09T23:45:47.754Z",
    "id": "b66afd02-b687-11ef-8dba-ec9dda21f2f7",
    "repository": "OpenSearch",
    "type": "pull_request_review"
  },
  "fields": {
    "created_at": [
      "2024-12-09T23:45:47.754Z"
    ]
  },
  "sort": [
    1733787947754
  ]
}

Yes we can have a list/dashboard of org members vs their engagement in the org, adding @bshien to provide more details on this. Also due to the limited seats we can consider a curated list of events and monitor them to add/update the triage group accordingly.
Adding @getsaurabh02

@dblock
Copy link
Member

dblock commented Dec 10, 2024

@peterzhuamazon Is there any reason for someone who's not part of the triage group (or a maintainer of a project) to be an org member? isn't that only for team memberships?

@bshien
Copy link

bshien commented Dec 10, 2024

The metrics project today collects user (contributor) activities, example

{
  "_index": "github-user-activity-events-12-2024",
  "_id": "b66afd02-b687-11ef-8dba-ec9dda21f2f7",
  "_version": 1,
  "_score": null,
  "_source": {
    "sender": "msfroh",
    "organization": "opensearch-project",
    "action": "submitted",
    "created_at": "2024-12-09T23:45:47.754Z",
    "id": "b66afd02-b687-11ef-8dba-ec9dda21f2f7",
    "repository": "OpenSearch",
    "type": "pull_request_review"
  },
  "fields": {
    "created_at": [
      "2024-12-09T23:45:47.754Z"
    ]
  },
  "sort": [
    1733787947754
  ]
}

Yes we can have a list/dashboard of org members vs their engagement in the org, adding @bshien to provide more details on this. Also due to the limited seats we can consider a curated list of events and monitor them to add/update the triage group accordingly. Adding @getsaurabh02

With the GitHub Events from all users in the S3 Data Lake indexed into the Metrics cluster, as long as we can obtain a list of the org members from an API, we can generate visualizations similar to the Maintainer Dashboard for these users as well.

@peterzhuamazon
Copy link
Member

@peterzhuamazon Is there any reason for someone who's not part of the triage group (or a maintainer of a project) to be an org member? isn't that only for team memberships?

If someone needs to be a maintainer or in triage group then we have to add them.
Else, no. They will still have readonly access to the repos.

Thanks.

@peterzhuamazon peterzhuamazon moved this from 🆕 New to 🏗 In progress in Engineering Effectiveness Board Dec 10, 2024
@peterzhuamazon
Copy link
Member

peterzhuamazon commented Dec 10, 2024

Hi @dblock @prudhvigodithi ,

I think we can start baseline with two criteria:

  1. whether people are not part of the opensearch org
  2. whether people have update an issue in the past 3-6 months.

Once identified we would need to remove them from the org in order to release the seats. Then they will be auto remove from the triage team as well.

Thanks.

@peterzhuamazon peterzhuamazon moved this from 🏗 In progress to ⌛ On Hold in Engineering Effectiveness Board Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ⌛ On Hold
Development

No branches or pull requests

6 participants