Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Apache Lucene 9.11 snapshot in main to include commit 8d7bf86bbeccefe66ef67d424ffc748e56410e84 #13848

Closed
navneet1v opened this issue May 27, 2024 · 5 comments · Fixed by #13850
Assignees
Labels

Comments

@navneet1v
Copy link
Contributor

navneet1v commented May 27, 2024

Is your feature request related to a problem? Please describe

I am working on Integrating KNNVectorsFormat in k-NN plugin for native engines(faiss/nmslib). To ensure that formats provided added in plugins can also be picked by SPI, I added this change in Lucene: apache/lucene@8d7bf86 which is approved and merged in branch_9x and main of Lucene.

Describe the solution you'd like

I am creating this request to pull in the changes from Lucene at-least till commit in main branch of Opensearch.

The last upgrade was done a month back. Ref: 39ac2df

Related component

Other

Describe alternatives you've considered

For doing development I am currently building Lucene and Opensearch locally to ensure everything works.

Additional context

Ref: opensearch-project/k-NN#1087

@navneet1v
Copy link
Contributor Author

cc: @msfroh , @reta

@reta
Copy link
Collaborator

reta commented May 27, 2024

@navneet1v I've triggered the Apache Lucene snapshot publishing, the latest ones 9.11.0-snapshot-4be6531 should be available so you could bump the version.

@navneet1v
Copy link
Contributor Author

@reta thanks. Sure do let me know if there are any action items from my side.

@reta
Copy link
Collaborator

reta commented May 27, 2024

@reta thanks. Sure do let me know if there are any action items from my side.

Please open the pull request with version update https://github.com/opensearch-project/OpenSearch/blob/994bfae0c0beddd8416ab88ed6138e2792638c4e/buildSrc/version.properties#L1C1-L3C1, 9.11.0-snapshot-fb97840 -> 9.11.0-snapshot-4be6531, thank you

@navneet1v
Copy link
Contributor Author

@reta thanks. Sure do let me know if there are any action items from my side.

Please open the pull request with version update https://github.com/opensearch-project/OpenSearch/blob/994bfae0c0beddd8416ab88ed6138e2792638c4e/buildSrc/version.properties#L1C1-L3C1, 9.11.0-snapshot-fb97840 -> 9.11.0-snapshot-4be6531, thank you

Raised the PR: #13850

@navneet1v navneet1v self-assigned this May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants