You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
Coming from #1379, docker is required to build. But there seems to be code in place trying to say "if you don't have docker, that's ok, I'll just skip those parts". That doesn't work.
Describe the solution you'd like
Skip distribution:docker* if docker is not available.
Additional context
Docker (checked [/usr/bin/docker, /usr/local/bin/docker, C:\Program Files\Docker\Docker\resources\bin\docker.exe]) is required to run the following tasks:
:distribution:docker:buildArm64DockerImage
:distribution:docker:buildDockerImage
you can address this by attending to the reported issue, or removing the offending tasks from being executed.
To reproduce, return null from DockerSupportServices.java, private Optional<String> getDockerPath() or run on Windows.
The text was updated successfully, but these errors were encountered:
dblock
added
enhancement
Enhancement or improvement to existing feature or request
help wanted
Extra attention is needed
bug
Something isn't working
and removed
enhancement
Enhancement or improvement to existing feature or request
labels
Oct 21, 2021
dblock
changed the title
Do not require docker to build
Docker is required to build on Windows
Oct 21, 2021
dblock
changed the title
Docker is required to build on Windows
Docker is required to build
Oct 21, 2021
Is your feature request related to a problem? Please describe.
Coming from #1379, docker is required to build. But there seems to be code in place trying to say "if you don't have docker, that's ok, I'll just skip those parts". That doesn't work.
Describe the solution you'd like
Skip
distribution:docker*
if docker is not available.Additional context
To reproduce, return
null
fromDockerSupportServices.java
,private Optional<String> getDockerPath()
or run on Windows.Current workaround:
The text was updated successfully, but these errors were encountered: