Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker is required to build #1406

Open
dblock opened this issue Oct 21, 2021 · 2 comments
Open

Docker is required to build #1406

dblock opened this issue Oct 21, 2021 · 2 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@dblock
Copy link
Member

dblock commented Oct 21, 2021

Is your feature request related to a problem? Please describe.

Coming from #1379, docker is required to build. But there seems to be code in place trying to say "if you don't have docker, that's ok, I'll just skip those parts". That doesn't work.

Describe the solution you'd like

Skip distribution:docker* if docker is not available.

Additional context

Docker (checked [/usr/bin/docker, /usr/local/bin/docker, C:\Program Files\Docker\Docker\resources\bin\docker.exe]) is required to run the following tasks:
:distribution:docker:buildArm64DockerImage
:distribution:docker:buildDockerImage
you can address this by attending to the reported issue, or removing the offending tasks from being executed.

To reproduce, return null from DockerSupportServices.java, private Optional<String> getDockerPath() or run on Windows.

Current workaround:

$ ./gradlew build -x ":distribution:docker:buildArm64DockerImage" -x ":distribution:docker:buildDockerImage"
@dblock dblock added enhancement Enhancement or improvement to existing feature or request help wanted Extra attention is needed bug Something isn't working and removed enhancement Enhancement or improvement to existing feature or request labels Oct 21, 2021
@dblock dblock changed the title Do not require docker to build Docker is required to build on Windows Oct 21, 2021
@dblock dblock changed the title Docker is required to build on Windows Docker is required to build Oct 21, 2021
@reta reta mentioned this issue Oct 22, 2021
1 task
@rursprung
Copy link
Contributor

since i just ran into this issue:

But there seems to be code in place trying to say "if you don't have docker, that's ok, I'll just skip those parts". That doesn't work.

where'd you see that code? i only see the explicit failure implemented here:

void failIfDockerUnavailable(List<String> tasks) {

@dblock
Copy link
Member Author

dblock commented May 5, 2022

Been a while since I wrote this TBH. I did a bit of searching and can't remember what I meant anymore :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants