-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce Serbian analyzer #14571
base: main
Are you sure you want to change the base?
Introduce Serbian analyzer #14571
Conversation
4b41c2a
to
1812901
Compare
❌ Gradle check result for 4b41c2a: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 1812901: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Veljko Potparic <[email protected]>
Signed-off-by: Veljko Potparic <[email protected]>
e7194cf
to
8f401e6
Compare
❌ Gradle check result for e7194cf: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 8f401e6: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #14571 +/- ##
============================================
- Coverage 71.71% 71.65% -0.07%
+ Complexity 62179 62173 -6
============================================
Files 5125 5126 +1
Lines 292444 292455 +11
Branches 42257 42258 +1
============================================
- Hits 209720 209552 -168
- Misses 65434 65653 +219
+ Partials 17290 17250 -40 ☔ View full report in Codecov by Sentry. |
*/ | ||
|
||
/* | ||
* Licensed to Elasticsearch under one or more contributor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new file so it doesn't need an Elasticsearch license. The license header above this one is sufficient.
Can you also please confirm that this is not a copy of any non-open-source-APLv2-elasticsearch code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with your assessment and will update the file accordingly.
I am not entirely sure how to verify non-open-source-APLv2-elasticsearch code on my own and would appreciate your confirmation to ensure everything is compliant.
This PR is stalled because it has been open for 30 days with no activity. |
This PR is stalled because it has been open for 30 days with no activity. |
@velizarvel want to finish this? |
@dblock yes, I would like to finish. Thank you for checking in! |
This PR is stalled because it has been open for 30 days with no activity. |
Serbian Analyzer enables users who work with the Serbian language to achieve better performance in text search and indexing. This analyzer uses specific tokenization and filtering rules tailored to the Serbian language, resulting in more accurate search results. Since Serbian Analyzer is already supported in the Apache Lucene library, its introduction into OpenSearch ensures compatibility and extends user capabilities.