Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Serbian analyzer #14571

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

velizarvel
Copy link

@velizarvel velizarvel commented Jun 27, 2024

Serbian Analyzer enables users who work with the Serbian language to achieve better performance in text search and indexing. This analyzer uses specific tokenization and filtering rules tailored to the Serbian language, resulting in more accurate search results. Since Serbian Analyzer is already supported in the Apache Lucene library, its introduction into OpenSearch ensures compatibility and extends user capabilities.

Copy link
Contributor

❌ Gradle check result for 4b41c2a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 1812901: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@velizarvel velizarvel force-pushed the introduce-serbian-analyzer branch from e7194cf to 8f401e6 Compare June 27, 2024 05:46
Copy link
Contributor

❌ Gradle check result for e7194cf: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 8f401e6: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

✅ Gradle check result for b1896da: SUCCESS

Copy link

codecov bot commented Jun 27, 2024

Codecov Report

Attention: Patch coverage is 27.27273% with 8 lines in your changes missing coverage. Please review.

Project coverage is 71.65%. Comparing base (2be25bb) to head (b1896da).
Report is 453 commits behind head on main.

Files with missing lines Patch % Lines
...earch/analysis/common/SerbianAnalyzerProvider.java 0.00% 6 Missing ⚠️
...rch/analysis/common/StemmerTokenFilterFactory.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #14571      +/-   ##
============================================
- Coverage     71.71%   71.65%   -0.07%     
+ Complexity    62179    62173       -6     
============================================
  Files          5125     5126       +1     
  Lines        292444   292455      +11     
  Branches      42257    42258       +1     
============================================
- Hits         209720   209552     -168     
- Misses        65434    65653     +219     
+ Partials      17290    17250      -40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

*/

/*
* Licensed to Elasticsearch under one or more contributor
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new file so it doesn't need an Elasticsearch license. The license header above this one is sufficient.

Can you also please confirm that this is not a copy of any non-open-source-APLv2-elasticsearch code?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with your assessment and will update the file accordingly.
I am not entirely sure how to verify non-open-source-APLv2-elasticsearch code on my own and would appreciate your confirmation to ensure everything is compliant.

@opensearch-trigger-bot
Copy link
Contributor

This PR is stalled because it has been open for 30 days with no activity.

@opensearch-trigger-bot opensearch-trigger-bot bot added stalled Issues that have stalled and removed stalled Issues that have stalled labels Jul 30, 2024
@opensearch-trigger-bot
Copy link
Contributor

This PR is stalled because it has been open for 30 days with no activity.

@opensearch-trigger-bot opensearch-trigger-bot bot added stalled Issues that have stalled and removed stalled Issues that have stalled labels Aug 30, 2024
@dblock
Copy link
Member

dblock commented Sep 2, 2024

@velizarvel want to finish this?

@velizarvel
Copy link
Author

@dblock yes, I would like to finish. Thank you for checking in!

@opensearch-trigger-bot
Copy link
Contributor

This PR is stalled because it has been open for 30 days with no activity.

@opensearch-trigger-bot opensearch-trigger-bot bot added the stalled Issues that have stalled label Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stalled Issues that have stalled
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants