Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Missing validations in shallow snapshot V2 repo creation #15913

Closed
sachinpkale opened this issue Sep 12, 2024 · 2 comments
Closed

[BUG] Missing validations in shallow snapshot V2 repo creation #15913

sachinpkale opened this issue Sep 12, 2024 · 2 comments
Labels
bug Something isn't working Priority-High Storage:Snapshots

Comments

@sachinpkale
Copy link
Member

sachinpkale commented Sep 12, 2024 •
edited
Loading

Describe the bug

  • While creating repository for shallow snapshot V2, we have following validations missing:
    • There can be multiple repositories with the shallow v2 flag enabled.
    • Repo name can contain a delimiter that is used in the pinning entity

Without these validations, remote store data cleanup will not be straightforward and can lead to zombie data.
@sachinpkale sachinpkale added bug Something isn't working Storage:Snapshots labels Sep 12, 2024
@sachinpkale sachinpkale mentioned this issue Sep 12, 2024
Merged
3 tasks
@sachinpkale
Copy link
Member Author

Need to get this change in 2.17. PR: #15911

@ashking94
Copy link
Member

Closing this issue since the associated PR is already merged.
[Triage - attendees 1 2 3 4 5]

@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Storage Project Board Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working Priority-High Storage:Snapshots
Projects
Storage Project Board
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sachinpkale @ashking94