[BUG] Identity feature flag should be set to true while the feature is first released

[peternied]

Describe the bug

In 2.17 the identity feature flag was in place and is disabled by default. With #16024 backported to 2.x, in the identity feature is enabled with no way to disable. We have skipped past the step where its enabled by default and had several releases to confirm everything is working as expected.

I would advice caution with this feature roll out to be sure we aren't creating any blocking issue. Lets add the flag back but flip the state to enabled by default.

Additional Details

• Remove Identity FeatureFlag #16024

[peternied]

FYI @reta @cwperks

[cwperks]

Thank you for filing this issue @peternied! All usages of Identity are currently gated behind the Extensions FeatureFlag.

There are 2 locations where methods from IdentityService are called:

1. In RestSendToExtensionAction
2. In ExtensionsManager

There are no other usages. I think this qualifies as being under a feature flag, but let me know what you think.

[reta]

Thanks @peternied , adding to that, I believe this feature flag is not used at all in the wild (safe to remove). Also, all feature flags have to be disabled by default but we could flip it on in opensearch.yml if you think think we have to bring it back ( shiro plugin is not installed by default).

[peternied]

Thanks for double checking - false alarm!