Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bitmap Filtering Performance Improvement #16317

Open
bowenlan-amzn opened this issue Oct 14, 2024 · 0 comments · May be fixed by #16936
Open

Bitmap Filtering Performance Improvement #16317

bowenlan-amzn opened this issue Oct 14, 2024 · 0 comments · May be fixed by #16936
Assignees
Labels
Roadmap:Search Project-wide roadmap label Search:Performance Search:Query Capabilities v2.19.0 Issues and PRs related to version 2.19.0

Comments

@bowenlan-amzn
Copy link
Member

bowenlan-amzn commented Oct 14, 2024

We have pinned down the cause of slow bitmap filtering as reported by user.

Profliing shows most time are taken by these 2 places

  • Cost estimation of PointInSetQuery

https://github.com/apache/lucene/blob/1ebee9e6116b1dbc5bcd410b4180df1f9c4c9d50/lucene/core/src/java/org/apache/lucene/search/PointInSetQuery.java#L204-L207

  • Constructor of PointInSetQuery

https://github.com/apache/lucene/blob/1ebee9e6116b1dbc5bcd410b4180df1f9c4c9d50/lucene/core/src/java/org/apache/lucene/search/PointInSetQuery.java#L92-L124

We plan to implement a specialized index query for bitmap filtering.


See the below profiling results.
https://github.com/bowenlan-amzn/file-share/blob/99d4fe6285e8b17128d1dd34951114612a733740/data2_flamegraph_20241002-221330.html

A quick experiment to improve from @msfroh bowenlan-amzn@105f58c#diff-4fa5d4f7924d3efa290acf2bf6a6a7821c0c4be9b8edeb1d6471c9e0b14dc201R1556

Original PR #14774 #16317 (comment)

@bowenlan-amzn bowenlan-amzn self-assigned this Oct 14, 2024
@bowenlan-amzn bowenlan-amzn converted this from a draft issue Oct 14, 2024
@getsaurabh02 getsaurabh02 moved this from Todo to In-Review in Performance Roadmap Nov 11, 2024
@bowenlan-amzn bowenlan-amzn moved this from In-Review to In Progress in Performance Roadmap Dec 3, 2024
@getsaurabh02 getsaurabh02 added v2.19.0 Issues and PRs related to version 2.19.0 Roadmap:Search Project-wide roadmap label labels Jan 2, 2025
@bowenlan-amzn bowenlan-amzn linked a pull request Jan 3, 2025 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Roadmap:Search Project-wide roadmap label Search:Performance Search:Query Capabilities v2.19.0 Issues and PRs related to version 2.19.0
Projects
Status: New
Status: In Progress
Status: 🆕 New
Development

Successfully merging a pull request may close this issue.

2 participants