-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add optional config field to tool step #899
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #899 +/- ##
============================================
+ Coverage 78.07% 78.09% +0.01%
Complexity 995 995
============================================
Files 99 99
Lines 4621 4624 +3
Branches 431 431
============================================
+ Hits 3608 3611 +3
Misses 833 833
Partials 180 180 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but as mentioned should be merged only after ml commons PR is merged and we can then uncomment the lines in ToolStep and ToolStepTests
4769bbd
to
b8d2f0c
Compare
Signed-off-by: Daniel Widdis <[email protected]>
b8d2f0c
to
6acbb45
Compare
Signed-off-by: Daniel Widdis <[email protected]>
6acbb45
to
ee9e545
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, approved to unblock
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/flow-framework/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/flow-framework/backport-2.x
# Create a new branch
git switch --create backport/backport-899-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6a4bed82d6b86438762f02a1eb600cff20d9c8ca
# Push it to GitHub
git push --set-upstream origin backport/backport-899-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/flow-framework/backport-2.x Then, create a pull request where the |
* Add optional config field to tool step Signed-off-by: Daniel Widdis <[email protected]> * Complete TODOs now that upstream is merged Signed-off-by: Daniel Widdis <[email protected]> --------- Signed-off-by: Daniel Widdis <[email protected]>
Add optional config field to tool step (#899) * Add optional config field to tool step * Complete TODOs now that upstream is merged --------- Signed-off-by: Daniel Widdis <[email protected]>
Description
Adds the optional
config
map to theToolStep
Related Issues
Resolves #878
Draft, pending merge:
Check List
--signoff
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.