Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling the execution of JNI tests as a component of gradle builds or github pull request checks #1453

Open
heemin32 opened this issue Feb 5, 2024 · 2 comments
Labels
Maintenance Add support for new versions of OpenSearch/Dashboards from upstream

Comments

@heemin32
Copy link
Collaborator

heemin32 commented Feb 5, 2024

The tests located in https://github.com/opensearch-project/k-NN/tree/main/jni/tests are not running as part of the build process. This omission could result in merging code that contains unresolved test failures.

@navneet1v
Copy link
Collaborator

I created a PR: #1553 which enabled the jni tests via gradle command. Its working in my local but on CI it is failing without providing enough logs: https://github.com/opensearch-project/k-NN/actions/runs/8318658424/job/22769651249?pr=1553

Need to deep-dive further to understand what is happening.

@navneet1v navneet1v added Maintenance Add support for new versions of OpenSearch/Dashboards from upstream and removed enhancement labels Mar 18, 2024
@jmazanec15
Copy link
Member

@0ctopus13prime is taking it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Add support for new versions of OpenSearch/Dashboards from upstream
Projects
Status: Backlog
Development

No branches or pull requests

3 participants