Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]Block updation of knn.enabled flag. #2334

Open
harishbhakuni opened this issue Dec 13, 2024 · 1 comment · May be fixed by #2348
Open

[BUG]Block updation of knn.enabled flag. #2334

harishbhakuni opened this issue Dec 13, 2024 · 1 comment · May be fixed by #2348
Assignees
Labels
bug Something isn't working v2.19.0

Comments

@harishbhakuni
Copy link

harishbhakuni commented Dec 13, 2024

What is the bug?
Today, user can update index.knn flag even after an index is created which should not be allowed. Users can close the index, update this setting and open the index back which is not an expected behaviour. We have seen some issues due to this recently as well during version upgrades to 2.17.
Also, user can today restore an existing index with index.knn setting as true as an index with index.knn setting as false. we need to block this setting from getting updated during snapshot restore as well.

How can one reproduce the bug?
Steps to reproduce the behavior:

  1. Create a kNN enabled index.
  2. Close the index.
  3. Open the index.

What is the expected behavior?
knn.enabled setting should be final and should not be allowed to get updated.

Do you have any screenshots?
If applicable, add screenshots to help explain your problem.

Do you have any additional context?
This index setting should be made final, so that it cannot be updated even after closing the index.
Also, during snapshot restore, there is a list of index settings for which we do not support updation. We should add this setting in that list.

@harishbhakuni harishbhakuni added bug Something isn't working untriaged labels Dec 13, 2024
@yigithub yigithub assigned yigithub and unassigned yigithub Dec 18, 2024
@anntians
Copy link

I'm interested in working on this issue. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v2.19.0
Projects
Status: 2.19.0
Development

Successfully merging a pull request may close this issue.

3 participants