Skip to content

Commit 2f717c0

Browse files
Enable execute tool feature flag by default (#4296) (#4304)
1 parent 293e045 commit 2f717c0

File tree

3 files changed

+7
-4
lines changed

3 files changed

+7
-4
lines changed

common/src/main/java/org/opensearch/ml/common/settings/MLCommonsSettings.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -339,7 +339,7 @@ private MLCommonsSettings() {}
339339

340340
// Feature flag for execute tool API
341341
public static final Setting<Boolean> ML_COMMONS_EXECUTE_TOOL_ENABLED = Setting
342-
.boolSetting(ML_PLUGIN_SETTING_PREFIX + "execute_tools_enabled", false, Setting.Property.NodeScope, Setting.Property.Dynamic);
342+
.boolSetting(ML_PLUGIN_SETTING_PREFIX + "execute_tools_enabled", true, Setting.Property.NodeScope, Setting.Property.Dynamic);
343343
public static final String ML_COMMONS_EXECUTE_TOOL_DISABLED_MESSAGE =
344344
"The Execute Tool API is not enabled. To enable, please update the setting " + ML_COMMONS_EXECUTE_TOOL_ENABLED.getKey();
345345

plugin/src/test/java/org/opensearch/ml/settings/MLFeatureEnabledSettingTests.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -125,16 +125,16 @@ public void testMetricCollectionSettings() {
125125
@Test
126126
public void testToolExecuteSettings() {
127127
// Test initial values
128-
assertFalse(mlFeatureEnabledSetting.isToolExecuteEnabled());
128+
assertTrue(mlFeatureEnabledSetting.isToolExecuteEnabled());
129129

130130
// Simulate settings change
131-
Settings newSettings = Settings.builder().put(ML_COMMONS_EXECUTE_TOOL_ENABLED.getKey(), true).build();
131+
Settings newSettings = Settings.builder().put(ML_COMMONS_EXECUTE_TOOL_ENABLED.getKey(), false).build();
132132

133133
// Update settings through cluster service
134134
when(clusterService.getSettings()).thenReturn(newSettings);
135135
mlFeatureEnabledSetting = new MLFeatureEnabledSetting(clusterService, newSettings);
136136

137137
// Verify updated values
138-
assertTrue(mlFeatureEnabledSetting.isToolExecuteEnabled());
138+
assertFalse(mlFeatureEnabledSetting.isToolExecuteEnabled());
139139
}
140140
}

release-notes/opensearch-ml-common.release-notes-3.3.0.0.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ Compatible with OpenSearch and OpenSearch Dashboards version 3.3.0
3636
* [Agentic Search] Use same model for Agent and QPT ([#4262](https://github.com/opensearch-project/ml-commons/pull/4262))
3737
* Improve semantic fact extraction prompt and add JSON enforcement ([#4282](https://github.com/opensearch-project/ml-commons/pull/4282))
3838
* Improve user preference extraction prompt with XML-based structure ([#4288](https://github.com/opensearch-project/ml-commons/pull/4288))
39+
* Enable execute tool feature flag by default ([#4296](https://github.com/opensearch-project/ml-commons/pull/4296))
3940

4041
### Bug Fixes
4142
* Fix NPE when execute flow agent with mutli tenancy is off ([#4189](https://github.com/opensearch-project/ml-commons/pull/4189))
@@ -65,6 +66,8 @@ Compatible with OpenSearch and OpenSearch Dashboards version 3.3.0
6566
* Fix agent streaming with security enabled + error handling ([#4256](https://github.com/opensearch-project/ml-commons/pull/4256))
6667
* Fix llm result path; convert message to user prompt string ([#4283](https://github.com/opensearch-project/ml-commons/pull/4283))
6768
* Fix llm result path error ([#4292](https://github.com/opensearch-project/ml-commons/pull/4292))
69+
* Fix dimension update flow to allow embedding type update ([#4297](https://github.com/opensearch-project/ml-commons/pull/4297))
70+
* Verify llm before summarize session ([#4300](https://github.com/opensearch-project/ml-commons/pull/4300))
6871

6972
### Infrastructure
7073
* Update maintainer list ([#4139](https://github.com/opensearch-project/ml-commons/pull/4139))

0 commit comments

Comments
 (0)