Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add CPU and jvm heap memory circuit breakers for Neural Search and Text Embedding processor #1169

Open
joshpalis opened this issue Feb 4, 2025 · 1 comment
Assignees

Comments

@joshpalis
Copy link
Member

joshpalis commented Feb 4, 2025

Is your feature request related to a problem?

When using remote models for text embedding during the execution of a neural query or the ingestion of documents, the request is stored in memory while the natural language query text is processed into vector embeddings. Depending on the latency of the response, it is possible that multiple requests can sit in memory and become detrimental to other tasks currently being handled by OpenSearch.

What solution would you like?

A circuit breaker for both memory and cpu utilization should be added to reject additional requests if the thresholds are breached

What alternatives have you considered?

n/a

Do you have any additional context?

Hybrid Search currently has circuit breakers integrated with the normalization processor. Since neural search does not require any use of search pipelines, we cannot follow the same pattern.

@heemin32
Copy link
Collaborator

heemin32 commented Feb 4, 2025

Wouldn't it be handled by OpenSearch core level already? I think the queue for query request is 1,000 and more than that request will be rejected anyway?

@joshpalis joshpalis changed the title [FEATURE] Add CPU and jvm heap memory circuit breakers for Neural Search [FEATURE] Add CPU and jvm heap memory circuit breakers for Neural Search and Text Embedding processor Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants