-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] MappingGenericProperty should have optional fields #703
Comments
@alex-at-cascade would you like to take a crack at fixing this? :) |
Sure thing! I'll ramp up on the contribution guidelines. |
alex-at-cascade
added a commit
to alex-at-cascade/opensearch-js
that referenced
this issue
Jan 30, 2024
Signed-off-by: Alex Dommasch <[email protected]>
alex-at-cascade
added a commit
to alex-at-cascade/opensearch-js
that referenced
this issue
Jan 30, 2024
…-project#703) Signed-off-by: Alex Dommasch <[email protected]>
5 tasks
alex-at-cascade
added a commit
to alex-at-cascade/opensearch-js
that referenced
this issue
Jan 30, 2024
…-project#703) Signed-off-by: Alex Dommasch <[email protected]>
alex-at-cascade
added a commit
to alex-at-cascade/opensearch-js
that referenced
this issue
Feb 5, 2024
…-project#703) Signed-off-by: alex-at-cascade <[email protected]>
dblock
pushed a commit
that referenced
this issue
Feb 6, 2024
Signed-off-by: alex-at-cascade <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What is the bug?
The type definition for MappingGenericProperty has mandatory fields
How can one reproduce the bug?
Try to compile this code:
An error is reported:
What is the expected behavior?
It should compile ok.
What is your host/environment?
node 18, typescript 5.2.2
Do you have any screenshots?
N/A
Do you have any additional context?
It appears that the other similar types do have optional fields, but the "generic" version is the odd one out.
The text was updated successfully, but these errors were encountered: