Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PROPOSAL] Enable branch protection, require 1 or 2 PR reviewers #9

Open
dblock opened this issue Jun 30, 2023 · 1 comment
Open

[PROPOSAL] Enable branch protection, require 1 or 2 PR reviewers #9

dblock opened this issue Jun 30, 2023 · 1 comment

Comments

@dblock
Copy link
Member

dblock commented Jun 30, 2023

What/Why

What are you proposing?

Enable branch protection to require pull requests.

What users have asked for this feature?

We want more 👀 on all the code changes.

What problems are you trying to solve?

Currently any maintainer can just write/merge code without anyone else seeing PRs.
@dblock
Copy link
Member Author

dblock commented Jun 30, 2023

For now, I enabled branch protection on * to require PRs and disallow direct pushes to main, but didn't set a minimum number of reviewers.

@dblock dblock changed the title [PROPOSAL] Enable branch protection [PROPOSAL] Enable branch protection, require 1 or 2 PR reviewers Jun 30, 2023
@getsaurabh02 getsaurabh02 moved this from 🆕 New to Later (6 months plus) in Search Project Board Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Search Project Board
Status: Later (6 months plus)
Milestone
No milestone
Development

No branches or pull requests
2 participants
@macohen @dblock