From 7e009a8c223fed5a07dd77c14e8a9e6872b6b4d2 Mon Sep 17 00:00:00 2001 From: Chris Helma Date: Thu, 9 Jan 2025 11:58:38 -0600 Subject: [PATCH] Updates per PR comments Signed-off-by: Chris Helma --- .../migrations/bulkload/EndToEndTest.java | 27 +------------------ .../OpenSearchWorkCoordinator.java | 2 +- 2 files changed, 2 insertions(+), 27 deletions(-) diff --git a/DocumentsFromSnapshotMigration/src/test/java/org/opensearch/migrations/bulkload/EndToEndTest.java b/DocumentsFromSnapshotMigration/src/test/java/org/opensearch/migrations/bulkload/EndToEndTest.java index cbbe7e1de..6c642f5a9 100644 --- a/DocumentsFromSnapshotMigration/src/test/java/org/opensearch/migrations/bulkload/EndToEndTest.java +++ b/DocumentsFromSnapshotMigration/src/test/java/org/opensearch/migrations/bulkload/EndToEndTest.java @@ -179,30 +179,5 @@ private void checkDocsWithRouting( Assertions.assertEquals("1", routing); } } - - // private static Stream scenarios_experimental() { - // var scenarios = Stream.builder(); - - // for (var sourceCluster : SupportedClusters.sources()) { - // for (var targetCluster : SupportedClusters.targets_experimental()) { - // scenarios.add(Arguments.of(sourceCluster, targetCluster)); - // } - // } - - // return scenarios.build(); - // } - - // @ParameterizedTest(name = "Source {0} to Target {1}") - // @MethodSource(value = "scenarios_experimental") - // public void migrationDocumentsExperimental( - // final SearchClusterContainer.ContainerVersion sourceVersion, - // final SearchClusterContainer.ContainerVersion targetVersion) throws Exception { - // try ( - // final var sourceCluster = new SearchClusterContainer(sourceVersion); - // final var targetCluster = new SearchClusterContainer(targetVersion) - // ) { - // migrationDocumentsWithClusters(sourceCluster, targetCluster); - // } - // } - + } diff --git a/RFS/src/main/java/org/opensearch/migrations/bulkload/workcoordination/OpenSearchWorkCoordinator.java b/RFS/src/main/java/org/opensearch/migrations/bulkload/workcoordination/OpenSearchWorkCoordinator.java index 651fea5a2..28563866b 100644 --- a/RFS/src/main/java/org/opensearch/migrations/bulkload/workcoordination/OpenSearchWorkCoordinator.java +++ b/RFS/src/main/java/org/opensearch/migrations/bulkload/workcoordination/OpenSearchWorkCoordinator.java @@ -31,7 +31,7 @@ import org.slf4j.LoggerFactory; public abstract class OpenSearchWorkCoordinator implements IWorkCoordinator { - // Create a stable logger that descendants can use, and we can predictable read from in tests + // Create a stable logger that descendants can use, and we can predictably read from in tests protected static final Logger log = LoggerFactory.getLogger(OpenSearchWorkCoordinator.class); public static final String INDEX_NAME = ".migrations_working_state";