From 6b31b048a1d1fd04ef465ffae99249d1af2cb9d1 Mon Sep 17 00:00:00 2001 From: Darshit Chanpura Date: Tue, 9 Jul 2024 12:50:59 -0400 Subject: [PATCH] [Backport 2.x] Update PULL_REQUEST_TEMPLATE to include an API spec change in the checklist. (#4533) (#4536) Signed-off-by: dblock Signed-off-by: Darshit Chanpura Co-authored-by: Daniel (dB.) Doubrovkine --- .github/pull_request_template.md | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index d738769f97..e5aa40ec2e 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -9,13 +9,17 @@ Is this a backport? If so, please add backport PR # and/or commits # +Do these changes introduce new permission(s) to be displayed in the static dropdown on the front-end? If so, please open a draft PR in the security dashboards plugin and link the draft PR here + ### Testing [Please provide details of testing done: unit testing, integration testing and manual testing] ### Check List - [ ] New functionality includes testing - [ ] New functionality has been documented +- [ ] New Roles/Permissions have a corresponding security dashboards plugin PR +- [ ] API changes companion pull request [created](https://github.com/opensearch-project/opensearch-api-specification/blob/main/DEVELOPER_GUIDE.md) - [ ] Commits are signed per the DCO using --signoff By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. -For more information on following Developer Certificate of Origin and signing off your commits, please check [here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin). +For more information on following Developer Certificate of Origin and signing off your commits, please check [here](https://github.com/opensearch-project/security/blob/main/CONTRIBUTING.md#developer-certificate-of-origin).