Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MacOS build support #2423

Closed
sandervandegeijn opened this issue Jan 30, 2023 · 10 comments
Closed

Add MacOS build support #2423

sandervandegeijn opened this issue Jan 30, 2023 · 10 comments
Labels
enhancement New feature or request triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable.

Comments

@sandervandegeijn
Copy link

Is your feature request related to a problem?
I tried to run the gradle tests per the readme.md file, but part of the tests failed because it tried to talk to either a LDAP-server or an opensearch cluster. It would be nice that these requirements could be met easilly (and documented how this is done). One option is to include a docker-compose file.

What solution would you like?
docker-compose file?

What alternatives have you considered?
Setting up stuff myself, but wasn't exactly clear how.

Do you have any additional context?
Ran the master branch tests last week

@sandervandegeijn sandervandegeijn added enhancement New feature or request untriaged Require the attention of the repository maintainers and may need to be prioritized labels Jan 30, 2023
@peternied
Copy link
Member

Hmm, maybe we need to clean up that readme documentation, ./gradlew test does everything you need nice and easy on your local machine, no external systems setup required. However, we have a ton more platform specific checks and workflows that are covered by our GitHub Actions.

Creating a pull request / draft PR is the best way to run the tests if you want to make sure things are in working order. Speaking only for myself, I don't mind PRs while you are still building out tests/components.

@peternied peternied removed the untriaged Require the attention of the repository maintainers and may need to be prioritized label Jan 30, 2023
@sandervandegeijn
Copy link
Author

sandervandegeijn commented Jan 31, 2023

Hm I tried to run the testsuite on macos arm arch, but out of the box the tests failed and I saw it try to connect to ldap/OS. With very little confidence in my Java-abilities I was trying to get the tests running to try to solve:

#987 (comment)

@peternied
Copy link
Member

Could you post the error, maybe a summary here and the full output to a gist?

@sandervandegeijn
Copy link
Author

Commands executed

git pull
./gradlew clean test

don't know if I can find the logs so I took screenshots during the process

image

image

image

image

image

image

image

image

image

image

image

image

image

image

image

image

image

95% success rate. Is 41 minutes normal? Ran it on a macbook pro m1 max 10c/32GB

@cwperks
Copy link
Member

cwperks commented Jan 31, 2023

@ict-one-nl What version of Java are you using? I would recommend using Java 11 or 17 to match the version of java run at build time in the Github Actions (GHA). See https://github.com/opensearch-project/security/blob/main/.github/workflows/ci.yml#L9-L37 for details on the command run via GHA.

I recommend SDKMan for managing local Java installations: https://sdkman.io/

@sandervandegeijn
Copy link
Author

sandervandegeijn commented Jan 31, 2023

Used the latest openjdk through homebrew, forced openjdk17 now, but - from eyeballing it - got the same errors. Ora19 JDK produces the same errors. Will try the Oracle JDK 17 tomorrow, thanks for the hints :)

@stephen-crawford
Copy link
Contributor

[Triage] Hi @ict-one-nl, thank you for filing this issue. Did trying the different JDK version fix anything? I know that we do not currently support MacOS though this is something in the works. I would be interested in hearing if you found any results or have any notes as we continue to develop platform support.

@stephen-crawford stephen-crawford added the triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable. label Feb 6, 2023
@sandervandegeijn
Copy link
Author

sandervandegeijn commented Feb 6, 2023

JDK-19 didn't fix it, JDK 17.0.6 gives the same result. Running Ventura 13.2 (22D49)

➜ security git:(main) ./gradlew clean test

image

@sandervandegeijn sandervandegeijn changed the title [FEATURE] include docker-compose file to satisfy requirements to run Gradle tests Add MacOS build support Feb 6, 2023
@davidlago davidlago mentioned this issue Aug 21, 2023
2 tasks
@davidlago
Copy link

This issue is being tracked here #1475

@sandervandegeijn
Copy link
Author

👍👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable.
Projects
None yet
Development

No branches or pull requests

5 participants