Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests] integration-tests are not being run on windows #3423

Closed
2 tasks
peternied opened this issue Sep 29, 2023 · 5 comments · Fixed by #3706
Closed
2 tasks

[Tests] integration-tests are not being run on windows #3423

peternied opened this issue Sep 29, 2023 · 5 comments · Fixed by #3706
Assignees
Labels
bug Something isn't working flaky-test Flaky Test issue good first issue These are recommended starting points for newcomers looking to make their first contributions. triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable. windows

Comments

@peternied
Copy link
Member

peternied commented Sep 29, 2023

Description

integration-tests are not being run on windows

Repro

  1. Checkout the 2.x branch that has the latest version of these tests
  2. Go to .github/workflows/ci.yml
  3. Find the integration-tests section, then update the platform
  4. Add windows-latest
  5. Commit change
  6. Push / create pull request and run the CI workflow

Additional Context

The tests themselves are solid, [here] is 10x runs of these same tests executed on the linux platform. Windows execution was dropped during the backporting process [1] to expedite the workflow.

Windows is seeming to have problems in general, tracking issue [2]

Exit Criteria

  • Root cause and specific issues that exist and see about resolving them.
  • Run the test at least 10 times and see no failures - how to do this
@peternied peternied added bug Something isn't working windows flaky-test Flaky Test issue labels Sep 29, 2023
@github-actions github-actions bot added the untriaged Require the attention of the repository maintainers and may need to be prioritized label Sep 29, 2023
@davidlago davidlago added good first issue These are recommended starting points for newcomers looking to make their first contributions. triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable. and removed untriaged Require the attention of the repository maintainers and may need to be prioritized labels Oct 2, 2023
@MaciejMierzwa
Copy link
Contributor

Hi, I'm looking into it

@davidlago
Copy link

@peternied could you please update the issue with the latest changes? Thanks!

@peternied
Copy link
Member Author

@MaciejMierzwa

I've updated the description to include the branch, which for the moment is only limited to 2.x - this should get you unblocked to look into this issue until the PR to main has been merged.

  1. Checkout the 2.x branch that has the latest version of these tests

@MaciejMierzwa
Copy link
Contributor

MaciejMierzwa commented Nov 14, 2023

Hi @peternied could it be that this issue is obsolete by now? Here's a draft PR that includes windows and runs integration tests 10 times. It branches out/points to branch 2.x. All integration-tests are green on the first pass, without any other changes.
#3706
EDIT: found some failing runs

@MaciejMierzwa
Copy link
Contributor

MaciejMierzwa commented Nov 27, 2023

Hi opened this bug since the test mentioned in PR is outside of scope for this task: #3772

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working flaky-test Flaky Test issue good first issue These are recommended starting points for newcomers looking to make their first contributions. triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable. windows
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants