Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize sensorhub-driver-misb-uas connection settings #47

Open
csdillard opened this issue Mar 10, 2022 · 0 comments
Open

Generalize sensorhub-driver-misb-uas connection settings #47

csdillard opened this issue Mar 10, 2022 · 0 comments

Comments

@csdillard
Copy link
Collaborator

To connect to a live stream, the MISB UAS driver has two connection parameters that specify a TCP endpoint in its configuration class: serverIpAddress and serverIpPort.

When the driver is started, the IP and port are just mashed together into one string with a ":" separator that ultimately gets passed directly to the ffmpeg libavformat library.

It would be more flexible to change the configuration class to just have one String property called something like "connectionString". This would allow you to use the full flexibility of libavformat's available protocols. For example, it would allow you to stream from an HTTP(S) source using an https URL string.

The new configuration class might be modified something like this:

package org.sensorhub.misb.stanag4609.comm;
public class Connection {
  // ... other stuff ...

  // Replacement for serverIpAddress and serverIpPort.
  // String that is passed to ffmpeg to tell it where to get streamed data.
  // https://www.ffmpeg.org/ffmpeg-protocols.html
  @DisplayInfo(label = "Connection String", desc = "Connection string that ffmpeg will use to connect to a MISB STANAG 4609 MPEG-TS stream")
  public String connectionString;
}

This would not be backwards compatible with existing configuration. But affected deployments would be trivially easy to update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant