Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define the workshops configuration in an individual configmap #1

Open
jorgemoralespou opened this issue May 17, 2019 · 1 comment
Open
Assignees
Labels
enhancement New feature or request

Comments

@jorgemoralespou
Copy link

Every workshop in homeroom should have a configmap, and homeroom should query and list configmaps with a specific label (e.g. homeroom) and add the contents of that config's map configuration to the homeroom configuration.

In this way, adding workshops don't require to re-deploy homeroom (as a rest url could be provided to reload config) and also it simplifies automation, as it's easier to include multiple configmaps than to patch the contents of a confimap as workshops/labs are added/deployed.

@GrahamDumpleton
Copy link
Collaborator

What was implemented related to this was that the application will scan for routes looking for annotations which identify workshops that have been added to the same group. At the same time, the workshop spawner will scan for an instance of this application with an annotation on the route for same group.

Result is that this application will auto populate with workshops in the same project, and the workshops will have the back link to this application automatically set up as well so that when restart session you end up back at this application.

The title and description for the workshop come from the annotations on the route for the workshop, which is set through WORKSHOP_TITLE and WORKSHOP_DESCRIPTION fields in the workshop scripts .workshop/settings.sh file.

So all dynamically works. The only issue is that you cannot control the order workshops appear in the list displayed by this application. Right now there is no deploy-homeroom.sh script in workshop scripts to make it easier to deploy this application.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants