Skip to content

Commit

Permalink
serial:baseload: add baseload accounting to padding pods
Browse files Browse the repository at this point in the history
In some of the tests we were skipping the basload accounting
this in turn led for some of the padding pod to keep
pending.

This commit fixes the problem by subtracting the baseload resources
from the padding pod request.

Signed-off-by: Talor Itzhak <[email protected]>
  • Loading branch information
Tal-or committed Jan 27, 2025
1 parent 0f3b426 commit 3417b56
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion test/e2e/serial/tests/workload_placement_tmpol.go
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,11 @@ var _ = Describe("[serial][disruptive][scheduler] numaresources workload placeme
for nIdx, nodeName := range e2efixture.ListNodeNames(nrtCandidateNames) {
nrtInfo, err := e2enrt.FindFromList(nrtCandidates, nodeName)
Expect(err).NotTo(HaveOccurred(), "missing NRT info for %q", nodeName)

//calculate a base load on the node
baseload, err := intbaseload.ForNode(fxt.Client, context.TODO(), nodeName)
Expect(err).ToNot(HaveOccurred(), "missing node load info for %q", nodeName)
klog.Infof("computed base load: %s", baseload)
baseload.Apply(paddingRes)
for zIdx, zone := range nrtInfo.Zones {
podName := fmt.Sprintf("padding-%d-%d", nIdx, zIdx)
padPod, err := makePaddingPod(fxt.Namespace.Name, podName, zone, paddingRes)
Expand Down

0 comments on commit 3417b56

Please sign in to comment.