Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump golangci-lint to 1.61 #1024

Merged
merged 2 commits into from
Sep 25, 2024
Merged

bump golangci-lint to 1.61 #1024

merged 2 commits into from
Sep 25, 2024

Conversation

ffromani
Copy link
Member

so we are ready to switch to golang >= 1.23 when time comes, being golangci-lint >= 1.60 the first compatible version.
See: golangci/golangci-lint#4837

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ffromani

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 24, 2024
@ffromani
tree: lint: prepare for golangci 1.61
3690dc6 
address and fix warnings from golangci 1.61

Signed-off-by: Francesco Romani <[email protected]>
@ffromani
golangci: bump to 1.61
0aa9ed9 
version >= 1.60 are needed for compatibility
with golang >= 1.23:
golangci/golangci-lint#4837

Signed-off-by: Francesco Romani <[email protected]>
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 24, 2024

@ffromani: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ci-e2e 0aa9ed9 link true /test ci-e2e
ci/prow/ci-install-e2e 0aa9ed9 link true /test ci-install-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ffromani ffromani merged commit 0cf04c0 into main Sep 25, 2024
11 of 14 checks passed
@ffromani ffromani deleted the bump-golangci-lint branch September 25, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrniranjan mrniranjan Awaiting requested review from mrniranjan

@swatisehgal swatisehgal Awaiting requested review from swatisehgal

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ffromani