Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add the internal/kloglevel package #1084

Merged
merged 1 commit into from
Nov 20, 2024
Merged

add the internal/kloglevel package #1084

merged 1 commit into from
Nov 20, 2024

Conversation

ffromani
Copy link
Member

introduce the internal/kloglevel to clean up the existing handling of

clean up the way we handle the klog verbosity,
which will enable also the future support
of dynamic log level adjustment

Signed-off-by: Francesco Romani <[email protected]>
@openshift-ci openshift-ci bot requested review from shajmakh and Tal-or November 20, 2024 12:56
Copy link
Contributor

openshift-ci bot commented Nov 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ffromani

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 20, 2024
@ffromani
Copy link
Member Author

/override ci/prow/ci-e2e-install-hypershift

still broken, fixing PR still pending

Copy link
Contributor

openshift-ci bot commented Nov 20, 2024

@ffromani: Overrode contexts on behalf of ffromani: ci/prow/ci-e2e-install-hypershift

In response to this:

/override ci/prow/ci-e2e-install-hypershift

still broken, fixing PR still pending

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ffromani
Copy link
Member Author

/hold

let's wait for #1071 to go in

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 20, 2024
@ffromani
Copy link
Member Author

/hold cancel

#1071 merged

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 20, 2024
@ffromani ffromani merged commit b972636 into main Nov 20, 2024
14 of 15 checks passed
@ffromani ffromani deleted the intloglevel-pkg branch November 20, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant