Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix maestro server template for ARO. #113

Merged
merged 1 commit into from
Jun 17, 2024
Merged

fix maestro server template for ARO. #113

merged 1 commit into from
Jun 17, 2024

Conversation

morvencao
Copy link
Contributor

@morvencao morvencao commented Jun 6, 2024 •
edited
Loading

  1. enable 'broadcast' subscription type for maestro server on ARO, because event grid MQTT server doesn't support shared subscription, see: https://learn.microsoft.com/en-us/azure/event-grid/mqtt-support#mqttv5-current-limitations
  2. remove duplicated DB SSL mode argument entry.

@morvencao
Copy link
Contributor Author

morvencao commented Jun 6, 2024 •
edited
Loading

/assign @geoberle @clyang82

clyang82
clyang82 approved these changes Jun 17, 2024
View reviewed changes
Copy link
Contributor

@clyang82 clyang82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clyang82
Copy link
Contributor

/ok-to-test

@clyang82
Copy link
Contributor

need rebase your PR to ensure the ut and integration pass.

@morvencao morvencao force-pushed the br_fix_maestro_server_template_for_aro branch from 6726edb to 2250b27 Compare June 17, 2024 06:53
@morvencao
Copy link
Contributor Author

rebased the code.

@clyang82 clyang82 merged commit b8eb4d7 into openshift-online:main Jun 17, 2024
5 checks passed
@morvencao morvencao deleted the br_fix_maestro_server_template_for_aro branch June 17, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clyang82 clyang82 clyang82 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@morvencao @clyang82