Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add maestro components arch and workflow. #152

Merged
merged 2 commits into from
Jul 8, 2024

Conversation

morvencao
Copy link
Contributor

@morvencao morvencao commented Jul 1, 2024

This PR aims to add documentation and diagrams for developers, providing an overview of Maestro components and detailing the resource CRUD workflow for both RESTful API and gRPC.

@morvencao morvencao force-pushed the br_add_maestro_overview branch 2 times, most recently from 3dba0c4 to 8001676 Compare July 2, 2024 07:58
@morvencao morvencao changed the title add maestro overview. add maestro componentc arch and workflow. Jul 2, 2024
Signed-off-by: morvencao <[email protected]>
@morvencao morvencao force-pushed the br_add_maestro_overview branch from 8001676 to b732a85 Compare July 2, 2024 08:35
@morvencao morvencao changed the title add maestro componentc arch and workflow. add maestro components arch and workflow. Jul 4, 2024
Copy link
Contributor

@clyang82 clyang82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe create a images folder and move all images to that folder.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a typo. Delete Eesource from Cluster -> Delete Resource from Cluster.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch, done!

Signed-off-by: morvencao <[email protected]>
@clyang82 clyang82 merged commit 6583de3 into openshift-online:main Jul 8, 2024
2 of 3 checks passed
@morvencao morvencao deleted the br_add_maestro_overview branch July 8, 2024 02:01
yanmxa pushed a commit to yanmxa/maestro that referenced this pull request Jul 9, 2024
* add maestro docs.

Signed-off-by: morvencao <[email protected]>

* address comments.

Signed-off-by: morvencao <[email protected]>

---------

Signed-off-by: morvencao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants