enhance log level and environment #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morvencao
force-pushed
the
br_agent_environment
branch
from
207deb0 to
3437521
Compare
|
e2e is broken by #203 |
morvencao
force-pushed
the
br_agent_environment
branch
from
3437521 to
486b7fc
Compare
morvencao
force-pushed
the
br_agent_environment
branch
from
486b7fc to
857d071
Compare
skeeey
reviewed
Oct 17, 2024
templates/agent-template-aro-hcp.yml
Outdated
| - name: KLOG_V | ||
| displayName: KLOG V Level | ||
| description: Log verbosity level | ||
| value: "1" |
There was a problem hiding this comment.
and may add more description? e.g. level 1 means error, level 2 means warning ...
There was a problem hiding this comment.
- updated default
KLOG_Venvironment in template to3. - added comments to explain the mapping between klog level and zap log level.
clyang82
reviewed
Oct 24, 2024
| // Initialize zap logger | ||
| zc := zap.NewDevelopmentConfig() | ||
| // Initialize zap logger based on environment | ||
| var zc zap.Config |
There was a problem hiding this comment.
for zap, it can support dynamically update the log level. that can help us on the troubleshooting. Can we do it instead of update the level in environment variable only? maybe define a configmap for the log level.
There was a problem hiding this comment.
after several attempts, I found that zap log supports dynamic log level changes, but klog does not.
morvencao
force-pushed
the
br_agent_environment
branch
from
2b44f50 to
22d22d4
Compare
morvencao
changed the title
clyang82
reviewed
Feb 17, 2025
| zc.Level = zap.NewAtomicLevelAt(zapcore.Level(0 - logLevel)) | ||
| // Disable stacktrace for production environment | ||
| zc.DisableStacktrace = true |
There was a problem hiding this comment.
You may move it to line 47 to reflect your comment.
There was a problem hiding this comment.
removed the comment.
Signed-off-by: morvencao <[email protected]>
Signed-off-by: morvencao <[email protected]>
morvencao
force-pushed
the
br_agent_environment
branch
from
22d22d4 to
8bd95c0
Compare
Signed-off-by: morvencao <[email protected]>
morvencao
force-pushed
the
br_agent_environment
branch
from
8bd95c0 to
6fbeb6b
Compare
|
/ok-to-test |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support consistent environment settings for maestro agent with maestro server.
Changed default log level to 4, so that cloudevents will be printed for debug.