Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update makefile with the local bin installs #826

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update makefile with the local bin installs #826

wants to merge 1 commit into from

Conversation

mnecas
Copy link
Collaborator

@mnecas mnecas commented Aug 25, 2023

Suggested changes

  • Add a local bin directory for all required dependencies
  • Add ginkgo-install to makefile
  • Add goimports-install to makefile

@mnecas mnecas force-pushed the update_makefile branch 2 times, most recently from a7eb50b to 7fb5864 Compare August 25, 2023 13:25
@mnecas
Copy link
Collaborator Author

mnecas commented Aug 28, 2023

@jhernand, could you please check it out?

jhernand
jhernand approved these changes Aug 28, 2023
View reviewed changes
Copy link
Collaborator

@jhernand jhernand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @mnecas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhernand jhernand jhernand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mnecas @jhernand