Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

approved status on ManualApproval CRD #9

Open
vdemeester opened this issue Oct 17, 2022 · 0 comments
Open

approved status on ManualApproval CRD #9

vdemeester opened this issue Oct 17, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@vdemeester
Copy link
Member

On "reconciliation", compute the approved status based on the spec (number of approval, name of the approvers, …). If it satisfies all the rules, mark it as approved.

In addition, once it's approved, mark it as "done" (and successfull or failed on denies) so that the rest of the Pipeline invoking this can continue (or fail).
@vdemeester vdemeester added the enhancement New feature or request label Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vdemeester