Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ready_for_review event PR in pipeline triggers #1953

Open
nickd-kt opened this issue Feb 20, 2025 · 1 comment · May be fixed by #1955
Open

Add support for ready_for_review event PR in pipeline triggers #1953

nickd-kt opened this issue Feb 20, 2025 · 1 comment · May be fixed by #1955

Comments

@nickd-kt
Copy link

nickd-kt commented Feb 20, 2025

Hey team,

In our org, we intentionally exclude draft PRs from pipeline triggers to reduce CI costs. The expectation is that CI should only run when a developer converts their PR from draft to active.

However, the event when a PR is converted to active (ready_for_review) is not currently supported, as seen in pullRequestOpenSyncEvent.

Would it be possible to add support for this event? From what I understand, it's already included in the GitHub's default PR event actions:

- opened
- synchronize
- reopened
- ready_for_review

Side note: @chmouel, I noticed that pullRequestOpenSyncEvent includes synchronized which is not a valid GitHub event action - see Events that trigger workflows.

@nickd-kt nickd-kt linked a pull request Feb 20, 2025 that will close this issue
7 tasks
@nickd-kt
Copy link
Author

Submitted a PR, hopefully that'll do it: #1955
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

1 participant