Skip to content

Conversation

@damdo
Copy link
Member

@damdo damdo commented Jul 21, 2025

Bump k8s dependencies to 1.33; go 1.24

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 21, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 21, 2025

@damdo: This pull request references OCPCLOUD-2937 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set.

In response to this:

Bump k8s dependencies to 1.33; go 1.24

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jul 21, 2025
@openshift-ci openshift-ci bot requested review from nrb and theobarberbany July 21, 2025 19:50
@theobarberbany
Copy link

Looks like vendoring has broken :( Vet/unit failing.

go vet ./...
# k8s.io/client-go/rest
vendor/k8s.io/client-go/rest/request.go:977:78: undefined: metav1.InitialEventsListBlueprintAnnotationKey
vendor/k8s.io/client-go/rest/request.go:979:89: undefined: metav1.InitialEventsListBlueprintAnnotationKey
# github.com/openshift/library-go/pkg/config/clusteroperator/v1helpers
vendor/github.com/openshift/library-go/pkg/config/clusteroperator/v1helpers/status.go:104:36: undefined: diff.StringDiff 

@damdo
Copy link
Member Author

damdo commented Jul 22, 2025

/test unit

5 similar comments
@damdo
Copy link
Member Author

damdo commented Jul 22, 2025

/test unit

@damdo
Copy link
Member Author

damdo commented Jul 22, 2025

/test unit

@damdo
Copy link
Member Author

damdo commented Jul 22, 2025

/test unit

@damdo
Copy link
Member Author

damdo commented Jul 22, 2025

/test unit

@damdo
Copy link
Member Author

damdo commented Jul 22, 2025

/test unit

@damdo
Copy link
Member Author

damdo commented Jul 22, 2025

/test e2e-aws-operator-techpreview

@damdo
Copy link
Member Author

damdo commented Jul 22, 2025

Regarding this test ci/prow/regression-clusterinfra-aws-ipi-cpms-allcases
It passed:

INFO[2025-07-22T11:52:42Z] Running step regression-clusterinfra-aws-ipi-cpms-allcases-openshift-extended-test. 
INFO[2025-07-22T15:03:47Z] Step regression-clusterinfra-aws-ipi-cpms-allcases-openshift-extended-test succeeded after 3h11m4s. 
INFO[2025-07-22T15:03:47Z] Step phase test succeeded after 3h11m4s.

but failed on the post case (see job run)

@damdo
Copy link
Member Author

damdo commented Jul 22, 2025

/test e2e-gcp-periodic-pre-techpreview

@damdo
Copy link
Member Author

damdo commented Jul 22, 2025

/assign @theobarberbany @RadekManak @racheljpg

@racheljpg
Copy link

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 22, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: racheljpg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 22, 2025
@damdo
Copy link
Member Author

damdo commented Jul 22, 2025

/hold

For testing to finish

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 22, 2025
@damdo
Copy link
Member Author

damdo commented Jul 22, 2025

The scaling tests known to not pass due to the operator briefly going to degraded and that invalidates a new invariant in the test. There is a fix up but not yet finished/merged #357

I am overriding the jobs until that's fixed. The I am happy for the CPMSO functionality to be covered by our CPMSO-e2e test which reports OK.

/override ci/prow/e2e-aws-ovn-etcd-scaling ci/prow/e2e-azure-ovn-etcd-scaling ci/prow/e2e-gcp-ovn-etcd-scaling ci/prow/e2e-vsphere-ovn-etcd-scaling

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 22, 2025

@damdo: Overrode contexts on behalf of damdo: ci/prow/e2e-aws-ovn-etcd-scaling, ci/prow/e2e-azure-ovn-etcd-scaling, ci/prow/e2e-gcp-ovn-etcd-scaling, ci/prow/e2e-vsphere-ovn-etcd-scaling

In response to this:

The scaling tests known to not pass due to the operator briefly going to degraded and that invalidates a new invariant in the test. There is a fix up but not yet finished/merged #357

I am overriding the jobs until that's fixed. The I am happy for the CPMSO functionality to be covered by our CPMSO-e2e test which reports OK.

/override ci/prow/e2e-aws-ovn-etcd-scaling ci/prow/e2e-azure-ovn-etcd-scaling ci/prow/e2e-gcp-ovn-etcd-scaling ci/prow/e2e-vsphere-ovn-etcd-scaling

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@damdo
Copy link
Member Author

damdo commented Jul 22, 2025

/test e2e-aws-operator-techpreview

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 22, 2025
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 67d8c21 and 2 for PR HEAD 7a84b70 in total

1 similar comment
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 67d8c21 and 2 for PR HEAD 7a84b70 in total

@damdo
Copy link
Member Author

damdo commented Jul 23, 2025

Failures in the ci/prow/e2e-aws-operator-techpreview job are unrelated to this PR as they are also present on main (see same failures for the same job on a no-op PR here)

Hence overriding

/override ci/prow/e2e-aws-operator-techpreview

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 23, 2025

@damdo: Overrode contexts on behalf of damdo: ci/prow/e2e-aws-operator-techpreview

In response to this:

Failures in the ci/prow/e2e-aws-operator-techpreview job are unrelated to this PR as they are also present on main (see same failures for the same job on a no-op PR here)

Hence overriding

/override ci/prow/e2e-aws-operator-techpreview

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@damdo
Copy link
Member Author

damdo commented Jul 24, 2025

/retest-required

1 similar comment
@damdo
Copy link
Member Author

damdo commented Jul 24, 2025

/retest-required

@damdo
Copy link
Member Author

damdo commented Jul 24, 2025

/test e2e-aws-ovn-serial-2of2

1 similar comment
@damdo
Copy link
Member Author

damdo commented Jul 24, 2025

/test e2e-aws-ovn-serial-2of2

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 24, 2025

@damdo: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/regression-clusterinfra-aws-ipi-cpms-allcases 7a84b70 link false /test regression-clusterinfra-aws-ipi-cpms-allcases

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 67d8c21 and 2 for PR HEAD 7a84b70 in total

@openshift-merge-bot openshift-merge-bot bot merged commit 5e1d028 into openshift:main Jul 24, 2025
36 of 37 checks passed
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-control-plane-machine-set-operator
This PR has been included in build ose-cluster-control-plane-machine-set-operator-container-v4.20.0-202507250015.p0.g5e1d028.assembly.stream.el9.
All builds following this will include this PR.

@damdo damdo changed the title OCPCLOUD-2937: Bump k8s dependencies to 1.33; go 1.24 OCPCLOUD-2937,OCPBUGS-57619: Bump k8s dependencies to 1.33; go 1.24 Jul 30, 2025
@openshift-ci-robot
Copy link

@damdo: Jira Issue OCPBUGS-57619: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-57619 has not been moved to the MODIFIED state.

In response to this:

Bump k8s dependencies to 1.33; go 1.24

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@damdo
Copy link
Member Author

damdo commented Jul 30, 2025

/jira refresh

@openshift-ci-robot
Copy link

@damdo: Jira Issue OCPBUGS-57619: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-57619 has been moved to the MODIFIED state.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants