OCPBUGS-62738:CNTRLPLANE-1315:Add OpenShift Tests Extension (OTE) for cluster-etcd-operator #1491
Conversation
This commit introduces a binary and supporting structure to enable the execution of OpenShift cluster-etcd-operator tests using the Open Test Environment (OTE). Changes: - Add cmd/cluster-etcd-operator-tests-ext/ with main.go - Add test/extended/ directory with comprehensive README.md and sanity test - Update Makefile with flexible OTE build targets and helper commands - Update Dockerfile to build and include test extension binary - Update go.mod with required dependencies for ginkgo and openshift-tests-extension - Update .gitignore to exclude OTE binary artifacts - Fix pre-existing platform-specific compilation error in bootstrap_ip_test.go Test suites: - openshift/cluster-etcd-operator/conformance/parallel - openshift/cluster-etcd-operator/conformance/serial - openshift/cluster-etcd-operator/optional/slow - openshift/cluster-etcd-operator/all
Add vendor dependencies for OTE framework: - github.com/onsi/ginkgo/v2 v2.21.0 - github.com/onsi/gomega v1.35.1 - github.com/openshift-eng/openshift-tests-extension v0.0.0-20250804142706-7b3ab438a292 - github.com/go-task/slim-sprig/v3 (transitive dependency) - golang.org/x/tools, golang.org/x/text, golang.org/x/net (transitive dependencies) Updated vendor/modules.txt to reflect new dependency tree.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
gangwgr
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@gangwgr: This pull request references CNTRLPLANE-1315 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
gangwgr
changed the title
openshift-ci-robot
added
the
jira/invalid-bug
|
@gangwgr: This pull request references Jira Issue OCPBUGS-62738, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@gangwgr: This pull request references Jira Issue OCPBUGS-62738, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@gangwgr: This pull request references Jira Issue OCPBUGS-62738, which is valid. 7 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest-required |
|
@gangwgr: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| COPY --from=builder /go/src/github.com/openshift/cluster-etcd-operator/bindata/bootkube/manifests /usr/share/bootkube/manifests/manifests/ | ||
| COPY --from=builder /go/src/github.com/openshift/cluster-etcd-operator/cluster-etcd-operator /usr/bin/ | ||
| COPY --from=builder /go/src/github.com/openshift/cluster-etcd-operator/tnf-setup-runner /usr/bin/ | ||
| COPY --from=builder /go/src/github.com/openshift/cluster-etcd-operator/cluster-etcd-operator-tests-ext.gz /usr/bin/ |
There was a problem hiding this comment.
disclaimer: I have no idea about the entire effort
is it desired that we ship the test binary with the production operator?
There was a problem hiding this comment.
This is indeed a problem. Currently, I'm considering separating it from component, see openshift/service-ca-operator#283
There was a problem hiding this comment.
@tjungblu This folllowing COPY is required, because we need this binary to run test in Prow CI. such as https://github.com/openshift/release/pull/70553/files#diff-f193fda3e6e07db2100d4ba66d6a7f19b3356ddf1a931438fce96a43be7dd0bfR98. This file is in a compressed format and is very small. Remembered that @stbenjam said test is part of our product, just like origin image we see it in our payload.
COPY --from=builder /go/src/github.com/openshift/cluster-etcd-operator/cluster-etcd-operator-tests-ext.gz /usr/bin/
|
/assign @dusk125 |
|
/approve |
openshift-ci
bot
added
backport-risk-assessed
|
/verified by ci runs |
openshift-ci-robot
added
the
verified
|
@gangwgr: This PR has been marked as verified by In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
|
@gangwgr: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dusk125, gangwgr, sandeepknd The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 0d7067c
into
openshift:release-4.20
|
@gangwgr: Jira Issue Verification Checks: Jira Issue OCPBUGS-62738 Jira Issue OCPBUGS-62738 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
6 participants
This pr backport of #1488
This introduces a binary and supporting structure to enable the execution of OpenShift cluster-etcd-operator tests using the Open Test Environment (OTE).
Changes:
Add cmd/cluster-etcd-operator-tests-ext/ with main.go
Add test/extended/ directory with comprehensive README.md and sanity test
Update Makefile with flexible OTE build targets and helper commands
Update Dockerfile to build and include test extension binary
Update go.mod with required dependencies for ginkgo and openshift-tests-extension
Add vendor dependencies for new OTE framework
Test suites:
openshift/cluster-etcd-operator/conformance/parallel
openshift/cluster-etcd-operator/conformance/serial
openshift/cluster-etcd-operator/optional/slow
openshift/cluster-etcd-operator/all