Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MON-3858: Add support to sysctl node-exporter collector #2339

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

MON-3858: Add support to sysctl node-exporter collector #2339

wants to merge 1 commit into from

Conversation

cgoncalves
Copy link

@cgoncalves cgoncalves commented May 7, 2024 •
edited
Loading

  • I added CHANGELOG entry for this change.
  • No user facing changes, so no entry in CHANGELOG was needed.

@cgoncalves
Copy link
Author

cc @danielmellado

@danielmellado
Copy link
Contributor

Seems to be pretty much in line with all other collectors, thanks Carlos!

@danielmellado
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 14, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgoncalves, danielmellado

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 14, 2024
@simonpasquier
Copy link
Contributor

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 14, 2024
simonpasquier
simonpasquier reviewed May 14, 2024
View reviewed changes
pkg/manifests/types.go Outdated Show resolved Hide resolved
pkg/manifests/types.go Outdated Show resolved Hide resolved
pkg/manifests/types.go Show resolved Hide resolved
pkg/manifests/types.go Outdated Show resolved Hide resolved
pkg/manifests/types.go Show resolved Hide resolved
pkg/manifests/manifests.go Outdated Show resolved Hide resolved
pkg/manifests/manifests.go Outdated Show resolved Hide resolved
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 3, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 3, 2024

New changes are detected. LGTM label has been removed.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 3, 2024

@cgoncalves: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn c90f629 link true /test e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@cgoncalves cgoncalves changed the title Add support to sysctl node-exporter collector MON-3858: Add support to sysctl node-exporter collector Jun 3, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 3, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 3, 2024 •
edited by openshift-ci bot
Loading

@cgoncalves: This pull request references MON-3858 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.17.0" version, but no target version was set.

In response to this:

  • I added CHANGELOG entry for this change.
  • No user facing changes, so no entry in CHANGELOG was needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 30, 2024
@cgoncalves
Copy link
Author

/remove-lifecycle stale

@openshift-ci openshift-ci bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 30, 2024
@cgoncalves
Copy link
Author

/retest

@cgoncalves
Copy link
Author

@simonpasquier, @danielmellado: please review. Thank you!

juzhao
juzhao reviewed Nov 28, 2024
View reviewed changes
CHANGELOG.md
@@ -5,6 +5,7 @@
- [#2302](https://github.com/openshift/cluster-monitoring-operator/issues/2302) Enable feature `extra-scrape-metrics` in Prometheus user-workload
- [#2319](https://github.com/openshift/cluster-monitoring-operator/pull/2319) Allow read-only access to the Alertmanager API (use `monitoring-alertmanager-view`).
- [#2078](https://github.com/openshift/cluster-monitoring-operator/pull/2078) Support exporting VPA metrics from KSM.
- [#2339](https://github.com/openshift/cluster-monitoring-operator/pull/2339) Add support to sysctl node-exporter collector
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am afraid the sysctl change should be under 4.19 now, master branch points to 4.19 now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juzhao juzhao juzhao left review comments

@simonpasquier simonpasquier simonpasquier left review comments

@danielmellado danielmellado Awaiting requested review from danielmellado

@marioferh marioferh Awaiting requested review from marioferh

Assignees

@danielmellado danielmellado

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cgoncalves @danielmellado @simonpasquier @openshift-ci-robot @openshift-bot @juzhao