-
Notifications
You must be signed in to change notification settings - Fork 464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drop openshift-sdn ports from host-port-registry #1664
base: master
Are you sure you want to change the base?
Conversation
A long time ago there was some confusion about openshift-sdn ports vs ovn-kubernetes ports vs standalone kube-proxy ports, but that's been fixed for a long time and continuing to reference it here confuses things more than it clarifies them. (Also, we still had some of the details wrong...)
Whoever added this thought it would be clever to not bother aligning the columns, and then promptly proceeded to make it clear why the columns needed to be aligned by accidentally making the body have more columns than the headings. Remove the "Protocol" column since it's not really useful for ports that aren't actually still used, and change "Since" to "Added" and "Removed".
(It's true that these ports aren't used in clusters with third-party network plugins, but you can figure that out on your own...)
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@danwinship: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Inactive enhancement proposals go stale after 28d of inactivity. See https://github.com/openshift/enhancements#life-cycle for details. Mark the proposal as fresh by commenting If this proposal is safe to close now please do so with /lifecycle stale |
/lgtm |
and some other cleanup...