Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop openshift-sdn ports from host-port-registry #1664

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

danwinship
Copy link
Contributor

and some other cleanup...

A long time ago there was some confusion about openshift-sdn ports vs
ovn-kubernetes ports vs standalone kube-proxy ports, but that's been
fixed for a long time and continuing to reference it here confuses
things more than it clarifies them. (Also, we still had some of the
details wrong...)
Whoever added this thought it would be clever to not bother aligning
the columns, and then promptly proceeded to make it clear why the
columns needed to be aligned by accidentally making the body have
more columns than the headings.

Remove the "Protocol" column since it's not really useful for ports
that aren't actually still used, and change "Since" to "Added" and
"Removed".
(It's true that these ports aren't used in clusters with third-party
network plugins, but you can figure that out on your own...)
Copy link
Contributor

openshift-ci bot commented Aug 16, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign frobware for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Aug 16, 2024

@danwinship: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-bot
Copy link

Inactive enhancement proposals go stale after 28d of inactivity.

See https://github.com/openshift/enhancements#life-cycle for details.

Mark the proposal as fresh by commenting /remove-lifecycle stale.
Stale proposals rot after an additional 7d of inactivity and eventually close.
Exclude this proposal from closing by commenting /lifecycle frozen.

If this proposal is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 14, 2024
@ricky-rav
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 20, 2024
@danwinship
Copy link
Contributor Author

/assign @trozet @dougbtv
for approval

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants