in-cluster DNS and load balancers on more platforms #1666
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
proposes adding in-cluster DNS and load balancers as an option for more platform types than just the current `baremetal` and `openstack`.
mhrivnak
force-pushed
the
in-cluster-network-services
branch
from
159b7fd
to
1e8dbd5
Compare
|
@mhrivnak: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| CloudControllerManager CloudControllerManager `json:"cloudControllerManager,omitempty"` | ||
|
|
||
| // InClusterLoadBalancer is an optional feature that uses haproxy and | ||
| // keepalived as loadbalancers running in the cluster. Is is useful in |
There was a problem hiding this comment.
| // keepalived as loadbalancers running in the cluster. Is is useful in | |
| // keepalived as loadbalancers running in the cluster. This is useful in |
| type InClusterLoadBalancer struct { | ||
| // APIVIPs contains the VIP(s) to use for internal API communication. In | ||
| // dual stack clusters it contains an IPv4 and IPv6 address, otherwise only | ||
| // one VIP | ||
| // | ||
| // +kubebuilder:validation:MaxItems=2 | ||
| // +kubebuilder:validation:UniqueItems=true | ||
| // +kubebuilder:validation:Format=ip | ||
| APIVIPs []string `json:"apiVIPs,omitempty"` | ||
|
|
||
| // IngressVIPs contains the VIP(s) to use for ingress traffic. In dual stack | ||
| // clusters it contains an IPv4 and IPv6 address, otherwise only one VIP | ||
| // | ||
| // +kubebuilder:validation:MaxItems=2 | ||
| // +kubebuilder:validation:UniqueItems=true | ||
| // +kubebuilder:validation:Format=ip | ||
| IngressVIPs []string `json:"ingressVIPs,omitempty"` | ||
| } |
There was a problem hiding this comment.
are the existing API/ingress VIP fields going to be deprecated/moved to this type?
| Enable stand-alone OpenShift clusters to be viable out-of-the-box in | ||
| environments that A) lack a suitable external DNS and/or load balancer | ||
| solution, and B) are not one of the platform types that already provide those | ||
| services in-cluster (`baremetal`, `openstack`, an `ovirt`). |
There was a problem hiding this comment.
| services in-cluster (`baremetal`, `openstack`, an `ovirt`). | |
| services in-cluster (`baremetal`, `openstack`, `vsphere`, and `ovirt`). |
|
cc @2uasimojo you might be interested in the install-config implications here |
Thanks @rvanderp3. I think these changes will be transparent to hive -- in fact, I'm not even sure if they're applicable to a hive-provisioned cluster -- but I'll keep an eye on this. |
proposes adding in-cluster DNS and load balancers as an option for more platform types than just the current
baremetalandopenstack.