Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AGENT-950: Implement Separate JWT Tokens for Different User Personas #9039

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

AGENT-950: Implement Separate JWT Tokens for Different User Personas #9039

wants to merge 1 commit into from

Conversation

pawanpinjarkar
Copy link
Contributor

  • Create 3 seperate JWT tokens- AGENT_AUTH_TOKEN, USER_AUTH_TOKEN, WATCHER_AUTH_TOKEN
  • Update the claim to set 'sub' to identify the user persona
  • Pass different headers in the curl requests depending on the user persona, for example, Watcher-Authorization header for watcher user persona

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 18, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 18, 2024 •
edited by openshift-ci bot
Loading

@pawanpinjarkar: This pull request references AGENT-950 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

  • Create 3 seperate JWT tokens- AGENT_AUTH_TOKEN, USER_AUTH_TOKEN, WATCHER_AUTH_TOKEN
  • Update the claim to set 'sub' to identify the user persona
  • Pass different headers in the curl requests depending on the user persona, for example, Watcher-Authorization header for watcher user persona

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 18, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from pawanpinjarkar. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pawanpinjarkar pawanpinjarkar marked this pull request as draft September 18, 2024 23:52
@pawanpinjarkar pawanpinjarkar marked this pull request as draft September 18, 2024 23:52
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 18, 2024
@pawanpinjarkar
AGENT-950: Implement Separate JWT Tokens for Different User Personas
41f0f0c 
- Create 3 seperate JWT tokens- AGENT_AUTH_TOKEN, USER_AUTH_TOKEN, WATCHER_AUTH_TOKEN
- Update the claim to set 'sub' to identify the user persona
- Pass different headers in the curl requests depending on the user persona, for example, Watcher-Authorization header for watcher user persona
- User generic name to specify auth token expiry
@pawanpinjarkar pawanpinjarkar force-pushed the create-seperate-tokens-4-each-user-authz branch from fbeb34c to 41f0f0c Compare September 19, 2024 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andfasano andfasano Awaiting requested review from andfasano

@bfournie bfournie Awaiting requested review from bfournie

Assignees
No one assigned
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pawanpinjarkar @openshift-ci-robot